diff mbox

[1/3] cleanup: remove not used header

Message ID 1483371890-289981-2-git-send-email-imammedo@redhat.com
State New
Headers show

Commit Message

Igor Mammedov Jan. 2, 2017, 3:44 p.m. UTC 
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 qom/object_interfaces.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Blake Jan. 3, 2017, 3:25 p.m. UTC | #1 
On 01/02/2017 09:44 AM, Igor Mammedov wrote:

perhaps s/not used/unused/ in the subject

Reviewed-by: Eric Blake <eblake@redhat.com>

> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  qom/object_interfaces.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> index ded4d84..4b880d0 100644
> --- a/qom/object_interfaces.c
> +++ b/qom/object_interfaces.c
> @@ -3,7 +3,6 @@
>  #include "qom/object_interfaces.h"
>  #include "qemu/module.h"
>  #include "qapi-visit.h"
> -#include "qapi/qobject-output-visitor.h"
>  #include "qapi/opts-visitor.h"
>  
>  void user_creatable_complete(Object *obj, Error **errp)
>
Andreas Färber Jan. 3, 2017, 3:26 p.m. UTC | #2 
Am 03.01.2017 um 16:25 schrieb Eric Blake:
> On 01/02/2017 09:44 AM, Igor Mammedov wrote:
> 
> perhaps s/not used/unused/ in the subject

... and qom: instead of cleanup: if this gets re-spun.

Andreas

> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>>  qom/object_interfaces.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
>> index ded4d84..4b880d0 100644
>> --- a/qom/object_interfaces.c
>> +++ b/qom/object_interfaces.c
>> @@ -3,7 +3,6 @@
>>  #include "qom/object_interfaces.h"
>>  #include "qemu/module.h"
>>  #include "qapi-visit.h"
>> -#include "qapi/qobject-output-visitor.h"
>>  #include "qapi/opts-visitor.h"
>>  
>>  void user_creatable_complete(Object *obj, Error **errp)
>>
>
Igor Mammedov Jan. 3, 2017, 4:54 p.m. UTC | #3 
On Tue, 3 Jan 2017 16:26:16 +0100
Andreas Färber <afaerber@suse.de> wrote:

> Am 03.01.2017 um 16:25 schrieb Eric Blake:
> > On 01/02/2017 09:44 AM, Igor Mammedov wrote:
> > 
> > perhaps s/not used/unused/ in the subject
> 
> ... and qom: instead of cleanup: if this gets re-spun.
sure

> 
> Andreas
> 
> > 
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > 
> >> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >> ---
> >>  qom/object_interfaces.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> >> index ded4d84..4b880d0 100644
> >> --- a/qom/object_interfaces.c
> >> +++ b/qom/object_interfaces.c
> >> @@ -3,7 +3,6 @@
> >>  #include "qom/object_interfaces.h"
> >>  #include "qemu/module.h"
> >>  #include "qapi-visit.h"
> >> -#include "qapi/qobject-output-visitor.h"
> >>  #include "qapi/opts-visitor.h"
> >>  
> >>  void user_creatable_complete(Object *obj, Error **errp)
> >>
> > 
> 
>
diff mbox

Patch

diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index ded4d84..4b880d0 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -3,7 +3,6 @@ 
 #include "qom/object_interfaces.h"
 #include "qemu/module.h"
 #include "qapi-visit.h"
-#include "qapi/qobject-output-visitor.h"
 #include "qapi/opts-visitor.h"
 
 void user_creatable_complete(Object *obj, Error **errp)