Patchwork RFA (arm): Fix PR45444

login
register
mail settings
Submitter Joern Rennecke
Date Nov. 12, 2010, 9:21 p.m.
Message ID <20101112162137.g84wnj3ms00sc0wo-nzlynne@webmail.spamcop.net>
Download mbox | patch
Permalink /patch/71015/
State New
Headers show

Comments

Joern Rennecke - Nov. 12, 2010, 9:21 p.m.
I haven't looked at the other patch, so I can't tell if mine is  
similar, better, or worse, but at any rate, I wrote this patch for  
INRIA, who have a Copyright
assignment for GCC on file with the FSF.

Built on i686-pc-linux-gnu with gcc (GCC) 4.6.0 20101111 (experimental) -
using an additional patch to cppbuiltin.c to get past PR46456.
2010-11-12  Joern Rennecke  <amylaar@spamcop.net>

	PR bootstrap/45444
	* config/arm/arm.c (locate_neon_builtin_icode): Initialize key.
	(arm_output_asm_insn) Add ATTRIBUTE_PRINTF_4.
Richard Earnshaw - Nov. 15, 2010, 1:17 p.m.
On Fri, 2010-11-12 at 16:21 -0500, Joern Rennecke wrote:
> I haven't looked at the other patch, so I can't tell if mine is  
> similar, better, or worse, but at any rate, I wrote this patch for  
> INRIA, who have a Copyright
> assignment for GCC on file with the FSF.
> 
> Built on i686-pc-linux-gnu with gcc (GCC) 4.6.0 20101111 (experimental) -
> using an additional patch to cppbuiltin.c to get past PR46456.
> plain text document attachment (arm-patch)
> 2010-11-12  Joern Rennecke  <amylaar@spamcop.net>
> 
> 	PR bootstrap/45444
> 	* config/arm/arm.c (locate_neon_builtin_icode): Initialize key.
> 	(arm_output_asm_insn) Add ATTRIBUTE_PRINTF_4.
> 

This is OK.

Thanks.

R.

[and no, it doesn't duplicate the method used in the patch in the PR.]

Patch

Index: config/arm/arm.c
===================================================================
--- config/arm/arm.c	(revision 166609)
+++ config/arm/arm.c	(working copy)
@@ -19045,7 +19045,9 @@  neon_builtin_compare (const void *a, con
 static enum insn_code
 locate_neon_builtin_icode (int fcode, neon_itype *itype)
 {
-  neon_builtin_datum key, *found;
+  neon_builtin_datum key
+    = { NULL, (neon_itype) 0, 0, { CODE_FOR_nothing }, 0, 0 };
+  neon_builtin_datum *found;
   int idx;
 
   key.base_fcode = fcode;
@@ -22900,7 +22902,7 @@  arm_count (int label,
    it to output_asm_insn.  Provides a mechanism to construct the
    output pattern on the fly.  Note the hard limit on the pattern
    buffer size.  */
-static void
+static void ATTRIBUTE_PRINTF_4
 arm_output_asm_insn (emit_f emit, int label, rtx *operands,
 		     const char *pattern, ...)
 {