diff mbox

[COMMITTED] malloc: Run tunables tests only if tunables are enabled

Message ID 20170101092139.8B2204048EEF4@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer Jan. 1, 2017, 9:21 a.m. UTC
Otherwise, the environment variable will not have any effect and
the test will fail.

2017-01-01  Florian Weimer  <fweimer@redhat.com>

	* malloc/Makefile (tests): Add tst-malloc-usable-tunables for
	have-tunables only.
	(tests-static): Add tst-malloc-usable-static-tunables for
	have-tunables only.

Comments

Siddhesh Poyarekar Jan. 1, 2017, 9:41 a.m. UTC | #1
On Sunday 01 January 2017 02:51 PM, Florian Weimer wrote:
> +ifneq (no,$(have-tunables))
> +tests += tst-malloc-usable-tunables
> +tests-static += tst-malloc-usable-static-tunables
> +endif

Ugh, of course.  Thanks!

Siddhesh
diff mbox

Patch

diff --git a/malloc/Makefile b/malloc/Makefile
index bbe5083..e93b83b 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -33,13 +33,16 @@  tests := mallocbug tst-malloc tst-valloc tst-calloc tst-obstack \
 	 tst-mallocfork2 \
 	 tst-interpose-nothread \
 	 tst-interpose-thread \
-	 tst-malloc-usable-tunables
 
 tests-static := \
 	 tst-interpose-static-nothread \
 	 tst-interpose-static-thread \
 	 tst-malloc-usable-static \
-	 tst-malloc-usable-static-tunables
+
+ifneq (no,$(have-tunables))
+tests += tst-malloc-usable-tunables
+tests-static += tst-malloc-usable-static-tunables
+endif
 
 tests += $(tests-static)
 test-srcs = tst-mtrace