| Message ID | 1483106478-1382-2-git-send-email-b.zolnierkie@samsung.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Dec 30, 2016 at 03:01:16PM +0100, Bartlomiej Zolnierkiewicz wrote: > When libata was merged m68k lacked IOMAP support. This has not been > true for a long time now so allow subsystem to be used on m68k. Is that dependency needed at all anymore? What exact functionality is missing on m32r and s390? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Friday, December 30, 2016 06:12:49 AM Christoph Hellwig wrote: > On Fri, Dec 30, 2016 at 03:01:16PM +0100, Bartlomiej Zolnierkiewicz wrote: > > When libata was merged m68k lacked IOMAP support. This has not been > > true for a long time now so allow subsystem to be used on m68k. > > Is that dependency needed at all anymore? What exact functionality > is missing on m32r and s390? * m32r: I don't know why it was restricted but it builds fine nowadays (I will fix it later in incremental patch) * s390: no PATA hardware, legacy IDE subsystem is also not supported Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 30, 2016 at 06:14:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > * m32r: I don't know why it was restricted but it builds fine nowadays > (I will fix it later in incremental patch) > > * s390: no PATA hardware, legacy IDE subsystem is also not supported s390 now has PCIe support, so PATA could be attached through a PCIe to PCI bridge in theory. And while that is very theoretical not having arch ifdefs is still something we should strive for, so I'd suggest removing the condition entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Sunday, January 08, 2017 02:08:23 AM Christoph Hellwig wrote: > On Fri, Dec 30, 2016 at 06:14:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > * m32r: I don't know why it was restricted but it builds fine nowadays > > (I will fix it later in incremental patch) > > > > * s390: no PATA hardware, legacy IDE subsystem is also not supported > > s390 now has PCIe support, so PATA could be attached through a PCIe to > PCI bridge in theory. And while that is very theoretical not having > arch ifdefs is still something we should strive for, so I'd suggest > removing the condition entirely. I agree. I will do it later unless someone beats me to it. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > When libata was merged m68k lacked IOMAP support. This has not been > true for a long time now so allow subsystem to be used on m68k. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 2c8be74..da19fc9 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -14,7 +14,7 @@ menuconfig ATA tristate "Serial ATA and Parallel ATA drivers (libata)" depends on HAS_IOMEM depends on BLOCK - depends on !(M32R || M68K || S390) || BROKEN + depends on !(M32R || S390) || BROKEN select SCSI select GLOB ---help---
When libata was merged m68k lacked IOMAP support. This has not been true for a long time now so allow subsystem to be used on m68k. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)