diff mbox

[v2,05/16] Improve generic memchr

Message ID 87mvfmcx6u.fsf@linux.vnet.ibm.com
State New
Headers show

Commit Message

Tulio Magno Quites Machado Filho Dec. 23, 2016, 6:33 p.m. UTC 
Richard Henderson <rth@twiddle.net> writes:

> -#ifdef weak_alias
> +
> +#ifndef MEMCHR
>  weak_alias (__memchr, memchr)
> -#endif
>  libc_hidden_builtin_def (memchr)
> +#endif

If you make this change, you also have to make the following change.
LGTM with it.
diff mbox

Patch

diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
index 9861337..6faf996 100644
--- a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
+++ b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c
@@ -23,12 +23,10 @@ 
 #undef weak_alias
 #define weak_alias(a, b)
 
-#ifdef SHARED
-# undef libc_hidden_builtin_def
-# define libc_hidden_builtin_def(name) \
-  __hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc);
-#endif
-
 extern __typeof (memchr) __memchr_ppc attribute_hidden;
 
 #include <string/memchr.c>
+
+#ifdef SHARED
+__hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc);
+#endif