From patchwork Wed Nov 10 18:59:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 70678 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BDEEEB7104 for ; Thu, 11 Nov 2010 06:00:35 +1100 (EST) Received: from localhost ([127.0.0.1]:53637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGFuL-00061W-8M for incoming@patchwork.ozlabs.org; Wed, 10 Nov 2010 14:00:33 -0500 Received: from [140.186.70.92] (port=35572 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGFtH-0005zo-7e for qemu-devel@nongnu.org; Wed, 10 Nov 2010 13:59:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGFtF-0003Yj-Fo for qemu-devel@nongnu.org; Wed, 10 Nov 2010 13:59:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGFtF-0003YV-61 for qemu-devel@nongnu.org; Wed, 10 Nov 2010 13:59:25 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAAIxOE5014572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Nov 2010 13:59:24 -0500 Received: from localhost (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oAAIxNrf016897; Wed, 10 Nov 2010 13:59:23 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Wed, 10 Nov 2010 16:59:05 -0200 Message-Id: <1289415546-19105-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1289415546-19105-1-git-send-email-lcapitulino@redhat.com> References: <1289415546-19105-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino --- monitor.c | 39 +++++++++++++++++++++++++++++++++++++++ qmp-commands.hx | 45 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 8cee35d..89513be 100644 --- a/monitor.c +++ b/monitor.c @@ -491,6 +491,45 @@ static int do_qmp_capabilities(Monitor *mon, const QDict *params, return 0; } +static int mon_set_cpu(int cpu_index); +static void handle_user_command(Monitor *mon, const char *cmdline); + +static int do_hmp_passthrough(Monitor *mon, const QDict *params, + QObject **ret_data) +{ + int ret = 0; + QString *qs; + Monitor *old_mon, hmp; + CharDriverState memchr; + + memset(&hmp, 0, sizeof(hmp)); + hmp.chr = &memchr; + qemu_chr_init_mem(hmp.chr); + + old_mon = cur_mon; + cur_mon = &hmp; + + if (qdict_haskey(params, "cpu-index")) { + ret = mon_set_cpu(qdict_get_int(params, "cpu-index")); + if (ret < 0) { + qerror_report(QERR_INVALID_PARAMETER_VALUE, "cpu-index", "a CPU number"); + goto out; + } + } + + handle_user_command(&hmp, qdict_get_str(params, "command-line")); + + qs = qemu_chr_mem_to_qs(hmp.chr); + if (qs) { + *ret_data = QOBJECT(qs); + } + +out: + cur_mon = old_mon; + qemu_chr_close_mem(hmp.chr); + return ret; +} + static int compare_cmd(const char *name, const char *list) { const char *p, *pstart; diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..b344096 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -761,6 +761,51 @@ Example: Note: This command must be issued before issuing any other command. +EQMP + + { + .name = "hmp_passthrough", + .args_type = "command-line:s,cpu-index:i?", + .params = "", + .help = "", + .user_print = monitor_user_noop, + .mhandler.cmd_new = do_hmp_passthrough, + }, + +SQMP +hmp_passthrough +--------------- + +Execute a Human Monitor command. + +Arguments: + +- command-line: the command name and its arguments, just like the + Human Monitor's shell (json-string) +- cpu-index: select the CPU number to be used by commands which access CPU + data, like 'info registers'. The Monitor selects CPU 0 if this + argument is not provided (json-int, optional) + +Example: + +-> { "execute": "hmp_passthrough", "arguments": { "command-line": "info kvm" } } +<- { "return": "kvm support: enabled\r\n" } + +Notes: + +(1) The Human Monitor is NOT an stable interface, this means that command + names, arguments and responses can change or be removed at ANY time. + Applications that rely on long term stability guarantees should NOT + use this command + +(2) Limitations: + + o This command is stateless, this means that commands that depend + on state information (such as getfd) might not work + + o Commands that prompt the user for data (eg. 'cont' when the block + device is encrypted) don't currently work + 3. Query Commands =================