diff mbox

[SRU,X] vmxnet3: segCnt can be 1 for LRO packets

Message ID 1481927039-17097-1-git-send-email-eric.desrochers@canonical.com
State New
Headers show

Commit Message

Eric Desrochers Dec. 16, 2016, 10:23 p.m. UTC 
From: Shrikrishna Khare <skhare@vmware.com>

BugLink: https://bugs.launchpad.net/bugs/1650635

The device emulation may send segCnt of 1 for LRO packets.

Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
Signed-off-by: Jin Heo <heoj@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 50219538ffc0493a2b451a3aa0191138ef8bfe9d)
Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>

Comments

Tim Gardner Dec. 17, 2016, 10:51 p.m. UTC | #1
Seth Forshee Dec. 19, 2016, 4:51 p.m. UTC | #2
Luis Henriques Dec. 19, 2016, 5:35 p.m. UTC | #3 
Applied to xenial master-next branch.

Cheers,
--
Luís
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index ba383cd..649a558 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1350,7 +1350,7 @@  vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
 				rcdlro = (struct Vmxnet3_RxCompDescExt *)rcd;
 
 				segCnt = rcdlro->segCnt;
-				BUG_ON(segCnt <= 1);
+				WARN_ON_ONCE(segCnt == 0);
 				mss = rcdlro->mss;
 				if (unlikely(segCnt <= 1))
 					segCnt = 0;