Message ID | 20161216092017.2560717-1-arnd@arndb.de |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, 16 Dec 2016, Arnd Bergmann wrote: > With posix timers having become optional, we get a build error with > the cpts time sync option of the CPSW driver: > > drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': > drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration] > > It really makes no sense to build this driver if we can't use PTP, > so it's better to go back to 'select PTP_1588_CLOCK' but instead > add a dependency on POSIX_TIMERS. Why not depend on PTP_1588_CLOCK directly instead? > Fixes: baa73d9e478f ("posix-timers: Make them configurable") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ethernet/ti/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > index 296c8efd0038..366e29ff8605 100644 > --- a/drivers/net/ethernet/ti/Kconfig > +++ b/drivers/net/ethernet/ti/Kconfig > @@ -76,7 +76,8 @@ config TI_CPSW > config TI_CPTS > tristate "TI Common Platform Time Sync (CPTS) Support" > depends on TI_CPSW || TI_KEYSTONE_NETCP > - imply PTP_1588_CLOCK > + depends on POSIX_TIMERS > + select PTP_1588_CLOCK > ---help--- > This driver supports the Common Platform Time Sync unit of > the CPSW Ethernet Switch and Keystone 2 1g/10g Switch Subsystem. > -- > 2.9.0 > >
On Fri, Dec 16, 2016 at 7:18 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > On Fri, 16 Dec 2016, Arnd Bergmann wrote: > >> With posix timers having become optional, we get a build error with >> the cpts time sync option of the CPSW driver: >> >> drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': >> drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration] >> >> It really makes no sense to build this driver if we can't use PTP, >> so it's better to go back to 'select PTP_1588_CLOCK' but instead >> add a dependency on POSIX_TIMERS. > > Why not depend on PTP_1588_CLOCK directly instead? Sorry for dropping the ball on this. I just noticed my two patches in my patch are still required, so I'm resending them now. I think using 'select' here is better for consistency as we use 'imply' elsewhere, and mixing the two might cause circular dependencies. If you still have concerns about this, please follow up on the resend. Arnd
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index 296c8efd0038..366e29ff8605 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -76,7 +76,8 @@ config TI_CPSW config TI_CPTS tristate "TI Common Platform Time Sync (CPTS) Support" depends on TI_CPSW || TI_KEYSTONE_NETCP - imply PTP_1588_CLOCK + depends on POSIX_TIMERS + select PTP_1588_CLOCK ---help--- This driver supports the Common Platform Time Sync unit of the CPSW Ethernet Switch and Keystone 2 1g/10g Switch Subsystem.
With posix timers having become optional, we get a build error with the cpts time sync option of the CPSW driver: drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration] It really makes no sense to build this driver if we can't use PTP, so it's better to go back to 'select PTP_1588_CLOCK' but instead add a dependency on POSIX_TIMERS. Fixes: baa73d9e478f ("posix-timers: Make them configurable") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/ti/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)