Patchwork [3/9] drivers/net/wireless/ath/debug.c: Use printf extension %pV

login
register
mail settings
Submitter Joe Perches
Date Nov. 10, 2010, 12:35 a.m.
Message ID <a6721b7e8c66b79da756a7b3d9dbf74e7663a1e9.1289348757.git.joe@perches.com>
Download mbox | patch
Permalink /patch/70599/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Joe Perches - Nov. 10, 2010, 12:35 a.m.
Using %pV reduces the number of printk calls and
eliminates any possible message interleaving from
other printk calls.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/wireless/ath/debug.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/net/wireless/ath/debug.c b/drivers/net/wireless/ath/debug.c
index dacfb23..a9600ba 100644
--- a/drivers/net/wireless/ath/debug.c
+++ b/drivers/net/wireless/ath/debug.c
@@ -19,14 +19,19 @@ 
 
 void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
 {
+	struct va_format vaf;
 	va_list args;
 
 	if (likely(!(common->debug_mask & dbg_mask)))
 		return;
 
 	va_start(args, fmt);
-	printk(KERN_DEBUG "ath: ");
-	vprintk(fmt, args);
+
+	vaf.fmt = fmt;
+	vaf.va = &args;
+
+	printk(KERN_DEBUG "ath: %pV", &vaf);
+
 	va_end(args);
 }
 EXPORT_SYMBOL(ath_print);