| Message ID | A614194ED15B4844BC4C9FB7F21FCD9222538BE8@HHMAIL01.hh.imgtec.org |
|---|---|
| State | New |
| Headers | show |
Toma Tabacu <Toma.Tabacu@imgtec.com> writes: > In the case of mips16-attributes.c, even though the (-mips16) option ensures > that -mmicromips will be overriden, there still is a dg-skip-if for -mmicromips. > > I think that it is not necessary and it actually decreases test coverage, > because it will cause the testsuite to skip this test instead of letting > (-mips16) do its job of overriding the global options. > > This patch removes the dg-skip-if for -mmicromips. > > Tested with mips-mti-elf. > > Regards, > Toma > > gcc/testsuite/ChangeLog: > > * gcc.target/mips/mips16-attributes.c: Remove dg-skip-if for > -mmicromips. OK, thanks. Matthew
Committed as r243649. Regards, Toma > Toma Tabacu writes: > > In the case of mips16-attributes.c, even though the (-mips16) option ensures > > that -mmicromips will be overriden, there still is a dg-skip-if for -mmicromips. > > > > I think that it is not necessary and it actually decreases test coverage, > > because it will cause the testsuite to skip this test instead of letting > > (-mips16) do its job of overriding the global options. > > > > This patch removes the dg-skip-if for -mmicromips. > > > > Tested with mips-mti-elf. > > > > Regards, > > Toma > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/mips/mips16-attributes.c: Remove dg-skip-if for > > -mmicromips. > > OK, thanks. > > Matthew
diff --git a/gcc/testsuite/gcc.target/mips/mips16-attributes.c b/gcc/testsuite/gcc.target/mips/mips16-attributes.c index e1497c0..421aa77 100644 --- a/gcc/testsuite/gcc.target/mips/mips16-attributes.c +++ b/gcc/testsuite/gcc.target/mips/mips16-attributes.c @@ -3,7 +3,6 @@ function. */ /* { dg-do run } */ /* { dg-options "(-mips16) (REQUIRES_STDLIB)" } */ -/* { dg-skip-if "" { *-*-* } { "-mmicromips" } { "" } } */ #include <stdlib.h>