From patchwork Tue Nov 9 14:15:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 70549 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2DFBCB6EED for ; Wed, 10 Nov 2010 01:15:57 +1100 (EST) Received: (qmail 29633 invoked by alias); 9 Nov 2010 14:15:53 -0000 Received: (qmail 29622 invoked by uid 22791); 9 Nov 2010 14:15:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Nov 2010 14:15:47 +0000 Received: by iwn42 with SMTP id 42so7856219iwn.20 for ; Tue, 09 Nov 2010 06:15:45 -0800 (PST) Received: by 10.231.167.146 with SMTP id q18mr5122721iby.163.1289312144563; Tue, 09 Nov 2010 06:15:44 -0800 (PST) Received: from yakj.usersys.redhat.com (nat-pool-brq-t.redhat.com [209.132.186.34]) by mx.google.com with ESMTPS id m10sm346748vcf.21.2010.11.09.06.15.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 09 Nov 2010 06:15:43 -0800 (PST) Message-ID: <4CD9578B.6010208@gnu.org> Date: Tue, 09 Nov 2010 15:15:39 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 MIME-Version: 1.0 To: David Edelsohn CC: Ian Lance Taylor , Richard Guenther , GCC Patches Subject: Re: PATCH RFA: Build system: Use AC_SYS_LARGEFILE References: In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > bconfig.h includes auto-host.h, which defines _LARGE_FILES. > > libcpp/directives.c also fails with similar errors, although it is not > obvious how headers are included in the wrong order > > I have no objection to enabling LARGE FILES support in GCC, but the > headers must be included in the correct order to allow bootstrap on > AIX. Is something like this enough? Index: libcpp/configure.ac =================================================================== --- libcpp/configure.ac (revision 166028) +++ libcpp/configure.ac (working copy) @@ -13,6 +13,7 @@ AC_PROG_INSTALL AC_PROG_CC AC_PROG_CXX AC_PROG_RANLIB +AC_SYS_LARGEFILE # See if we are building gcc with C++. # Do this early so setting lang to C++ affects following tests Index: gcc/gengtype-lex.l =================================================================== --- gcc/gengtype-lex.l (revision 166028) +++ gcc/gengtype-lex.l (working copy) @@ -23,6 +23,10 @@ along with GCC; see the file COPYING3. %{ #include "bconfig.h" + +/* stdio.h has been included already by the flex skeleton, so + defining _LARGE_FILES here would break bootstrap on AIX. */ +#undef _LARGE_FILES #include "system.h" #define malloc xmalloc