ACPI / blacklist: Make Dell Latitude 3350 ethernet work
diff mbox

Message ID 1481615664-24067-2-git-send-email-acelan.kao@canonical.com
State New
Headers show

Commit Message

AceLan Kao Dec. 13, 2016, 7:54 a.m. UTC
From: Michael Pobega <mpobega@neverware.com>

BugLink: http://bugs.launchpad.net/bugs/1648279 

The Dell Latitude 3350's ethernet card attempts to use a reserved
IRQ (18), resulting in ACPI being unable to enable the ethernet.

Adding it to acpi_rev_dmi_table[] helps to work around this problem.

Signed-off-by: Michael Pobega <mpobega@neverware.com>
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

(backported from commit 708f5dcc21ae9b35f395865fc154b0105baf4de4)
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/acpi/blacklist.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Colin King Dec. 13, 2016, 9:21 a.m. UTC | #1
On 13/12/16 07:54, AceLan Kao wrote:
> From: Michael Pobega <mpobega@neverware.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1648279 
> 
> The Dell Latitude 3350's ethernet card attempts to use a reserved
> IRQ (18), resulting in ACPI being unable to enable the ethernet.
> 
> Adding it to acpi_rev_dmi_table[] helps to work around this problem.
> 
> Signed-off-by: Michael Pobega <mpobega@neverware.com>
> [ rjw: Changelog ]
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> (backported from commit 708f5dcc21ae9b35f395865fc154b0105baf4de4)
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index b002188..94e4390 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -417,6 +417,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		      DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9343"),
>  		},
>  	},
> +	/*
> +	 * Resolves a quirk with the Dell Latitude 3350 that
> +	 * causes the ethernet adapter to not function.
> +	 */
> +	{708f5dcc21ae9b35f395865fc154b0105baf4de4
> +	 .callback = dmi_enable_rev_override,
> +	 .ident = "DELL Latitude 3350",
> +	 .matches = {
> +		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
> +		},
> +	},
>  #endif
>  	{}
>  };
> 

Comment: This is a recent commit (Nov-11) from linux-next and not hit
Linux yet, I guess it will land in the 4.10 merge very soon.

This quirk affects a small set of H/W and seems to do the trick, so I'm
OK with this fix.

Acked-by: Colin Ian King <colin.king@canonical.com>
Tim Gardner Dec. 13, 2016, 1:56 p.m. UTC | #2
Needs to be noted that this commit came from linux-next and should also
be applied to Yakkety.

Patch
diff mbox

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index b002188..94e4390 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -417,6 +417,18 @@  static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		      DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9343"),
 		},
 	},
+	/*
+	 * Resolves a quirk with the Dell Latitude 3350 that
+	 * causes the ethernet adapter to not function.
+	 */
+	{
+	 .callback = dmi_enable_rev_override,
+	 .ident = "DELL Latitude 3350",
+	 .matches = {
+		      DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		      DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"),
+		},
+	},
 #endif
 	{}
 };