| Message ID | 1481302167-28044-4-git-send-email-clg@kaod.org |
|---|---|
| State | Superseded |
| Headers | show |
On 12/09/2016 05:49 PM, Cédric Le Goater wrote: > This can be used to easily identify a chip on a system with multiple > chips. I don't think I understand what this patch does. It seems to me like this one should be wrapped into 1/5. > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > index 99302b0d7786..9119c0ca86b6 100644 > --- a/drivers/mtd/spi-nor/aspeed-smc.c > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, > nor->prepare = aspeed_smc_prep; > nor->unprepare = aspeed_smc_unprep; > > + mtd->name = of_get_property(child, "label", NULL); > + > ret = aspeed_smc_chip_setup_init(chip, r); > if (ret) > break; >
On 12/10/2016 05:03 AM, Marek Vasut wrote: > On 12/09/2016 05:49 PM, Cédric Le Goater wrote: >> This can be used to easily identify a chip on a system with multiple >> chips. > > I don't think I understand what this patch does. > It seems to me like this one should be wrapped into 1/5. Yes, but this is to open the discussion on the change required in the jedec,spi-nor binding. C. >> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> --- >> drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >> index 99302b0d7786..9119c0ca86b6 100644 >> --- a/drivers/mtd/spi-nor/aspeed-smc.c >> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >> @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, >> nor->prepare = aspeed_smc_prep; >> nor->unprepare = aspeed_smc_unprep; >> >> + mtd->name = of_get_property(child, "label", NULL); >> + >> ret = aspeed_smc_chip_setup_init(chip, r); >> if (ret) >> break; >> > >
On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater <clg@kaod.org> wrote: > This can be used to easily identify a chip on a system with multiple > chips. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Our userspace benefits from having this. Acked-by: Joel Stanley <joel@jms.id.au> > --- > drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > index 99302b0d7786..9119c0ca86b6 100644 > --- a/drivers/mtd/spi-nor/aspeed-smc.c > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, > nor->prepare = aspeed_smc_prep; > nor->unprepare = aspeed_smc_unprep; > > + mtd->name = of_get_property(child, "label", NULL); > + > ret = aspeed_smc_chip_setup_init(chip, r); > if (ret) > break; > -- > 2.7.4 >
On 12/12/2016 12:46 AM, Joel Stanley wrote: > On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater <clg@kaod.org> wrote: >> This can be used to easily identify a chip on a system with multiple >> chips. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Our userspace benefits from having this. > > Acked-by: Joel Stanley <joel@jms.id.au> Shouldn't such thing be part of core code then ? >> --- >> drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >> index 99302b0d7786..9119c0ca86b6 100644 >> --- a/drivers/mtd/spi-nor/aspeed-smc.c >> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >> @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, >> nor->prepare = aspeed_smc_prep; >> nor->unprepare = aspeed_smc_unprep; >> >> + mtd->name = of_get_property(child, "label", NULL); >> + >> ret = aspeed_smc_chip_setup_init(chip, r); >> if (ret) >> break; >> -- >> 2.7.4 >>
On 12/12/2016 03:27 AM, Marek Vasut wrote: > On 12/12/2016 12:46 AM, Joel Stanley wrote: >> On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater <clg@kaod.org> wrote: >>> This can be used to easily identify a chip on a system with multiple >>> chips. >>> >>> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> >> Our userspace benefits from having this. >> >> Acked-by: Joel Stanley <joel@jms.id.au> > > Shouldn't such thing be part of core code then ? yes. I will merge it in the next version. we already have the jedec,spi-nor label patch to discuss about the binding change. Thanks, C. >>> --- >>> drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >>> index 99302b0d7786..9119c0ca86b6 100644 >>> --- a/drivers/mtd/spi-nor/aspeed-smc.c >>> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >>> @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, >>> nor->prepare = aspeed_smc_prep; >>> nor->unprepare = aspeed_smc_unprep; >>> >>> + mtd->name = of_get_property(child, "label", NULL); >>> + >>> ret = aspeed_smc_chip_setup_init(chip, r); >>> if (ret) >>> break; >>> -- >>> 2.7.4 >>> > >
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c index 99302b0d7786..9119c0ca86b6 100644 --- a/drivers/mtd/spi-nor/aspeed-smc.c +++ b/drivers/mtd/spi-nor/aspeed-smc.c @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, nor->prepare = aspeed_smc_prep; nor->unprepare = aspeed_smc_unprep; + mtd->name = of_get_property(child, "label", NULL); + ret = aspeed_smc_chip_setup_init(chip, r); if (ret) break;
This can be used to easily identify a chip on a system with multiple chips. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- drivers/mtd/spi-nor/aspeed-smc.c | 2 ++ 1 file changed, 2 insertions(+)