| Message ID | 1481278287-23842-1-git-send-email-yegorslists@googlemail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote: > From: Yegor Yefremov <yegorslists@googlemail.com> > > 'include' was missing from path. > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > --- > Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt > index 164c7f3..5b20e20 100644 > --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt > +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt > @@ -44,7 +44,7 @@ Required properties: > reset status register > Cell #7 : Flags used to control reset behavior, > availible flags defined in the DT include > - file <dt-bindings/reset/ti-syscon.h> > + file <include/dt-bindings/reset/ti-syscon.h> There's pretty much equal mixture of include or not. Not really much point in fixing 1 instance if there's no clear correct way. Given it is written with <...>, that matches how you write the include statement. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring <robh@kernel.org> wrote: > On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote: >> From: Yegor Yefremov <yegorslists@googlemail.com> >> >> 'include' was missing from path. >> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> >> --- >> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt >> index 164c7f3..5b20e20 100644 >> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt >> @@ -44,7 +44,7 @@ Required properties: >> reset status register >> Cell #7 : Flags used to control reset behavior, >> availible flags defined in the DT include >> - file <dt-bindings/reset/ti-syscon.h> >> + file <include/dt-bindings/reset/ti-syscon.h> > > There's pretty much equal mixture of include or not. Not really much > point in fixing 1 instance if there's no clear correct way. Given it is > written with <...>, that matches how you write the include statement. OK I see the point of omitting include now. I was looking at this from VIM point of view. I cannot automatically jump to the file via 'gf'. Yegor -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt index 164c7f3..5b20e20 100644 --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt @@ -44,7 +44,7 @@ Required properties: reset status register Cell #7 : Flags used to control reset behavior, availible flags defined in the DT include - file <dt-bindings/reset/ti-syscon.h> + file <include/dt-bindings/reset/ti-syscon.h> SysCon Reset Consumer Nodes ===========================