diff mbox

net: socket: preferred __aligned(size) for control buffer

Message ID 1481201513-20783-1-git-send-email-kushwaha.a@samsung.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

kushwaha.a@samsung.com Dec. 8, 2016, 12:51 p.m. UTC 
From: Amit Kushwaha <kushwaha.a@samsung.com>

This patch cleanup checkpatch.pl warning
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
---
 net/socket.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Miller Dec. 8, 2016, 11:21 p.m. UTC | #1 
From: kushwaha.a@samsung.com
Date: Thu, 08 Dec 2016 18:21:53 +0530

> From: Amit Kushwaha <kushwaha.a@samsung.com>
> 
> This patch cleanup checkpatch.pl warning
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
> 
> Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>

Applied to net-next.
Sergei Shtylyov Dec. 9, 2016, 11:14 a.m. UTC | #2 
Hello!

On 12/8/2016 3:51 PM, kushwaha.a@samsung.com wrote:

> From: Amit Kushwaha <kushwaha.a@samsung.com>
>
> This patch cleanup checkpatch.pl warning
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
>
> Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
> ---
>  net/socket.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index e631894..5835383 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -1,3 +1,4 @@
> +

    Why?

>  /*
>   * NET		An implementation of the SOCKET network access protocol.
>   *
[...]

MBR, Sergei
diff mbox

Patch

diff --git a/net/socket.c b/net/socket.c
index e631894..5835383 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1,3 +1,4 @@ 
+
 /*
  * NET		An implementation of the SOCKET network access protocol.
  *
@@ -1918,7 +1919,7 @@  static int ___sys_sendmsg(struct socket *sock, struct user_msghdr __user *msg,
 	struct sockaddr_storage address;
 	struct iovec iovstack[UIO_FASTIOV], *iov = iovstack;
 	unsigned char ctl[sizeof(struct cmsghdr) + 20]
-	    __attribute__ ((aligned(sizeof(__kernel_size_t))));
+				__aligned(sizeof(__kernel_size_t));
 	/* 20 is size of ipv6_pktinfo */
 	unsigned char *ctl_buf = ctl;
 	int ctl_len;