| Message ID | 20161208105750.GA14898@cran64.bj.intel.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 8 Dec 2016 18:57:51 +0800, Yang, Yi wrote: > So ovs out of tree modules need to adapt to upstream kernel, any > kernel-related changes must be accepted by Linux kernel at first. I'm perfectly aware of that and I'm saying that your patch is unacceptable for upstream kernel. This is a long standing policy of the kernel: there's no way you can get a patch into the kernel to accommodate an out of tree kernel module. The policy is there for good reasons and as paradoxical as it may sound, it benefits the projects that employ out of tree modules in the long run. If Open vSwitch wants to carry a non-upstream patch, it's its choice and we can have that discussion but that's not something to discuss on netdev@vger nor propose for net-next. Jiri
On Thu, Dec 08, 2016 at 12:37:56PM +0100, Jiri Benc wrote: > On Thu, 8 Dec 2016 18:57:51 +0800, Yang, Yi wrote: > > So ovs out of tree modules need to adapt to upstream kernel, any > > kernel-related changes must be accepted by Linux kernel at first. > > I'm perfectly aware of that and I'm saying that your patch is > unacceptable for upstream kernel. This is a long standing policy of the > kernel: there's no way you can get a patch into the kernel to > accommodate an out of tree kernel module. The policy is there for good > reasons and as paradoxical as it may sound, it benefits the projects > that employ out of tree modules in the long run. > > If Open vSwitch wants to carry a non-upstream patch, it's its choice > and we can have that discussion but that's not something to discuss on > netdev@vger nor propose for net-next. > Jiri, according to your statement, we have to switch Linux 4.7 or above if we want to use ovs VxLAN-gpe, Ubuntu 16.04 has had new kernel, but it just use Linux kernel 4.4, you know Linux distributuions nerver uses the latest stable Linux kernel because they have their own patches to maintain, that will be a nightmare if they take the latest stable kernel. You know RHEL also follows the same philosophy. Current ovs master can be built on Ubuntu 14.04 which have Linux kernel 3.13, I think compatibility backward is very important, out of tree modules are very important to ovs. If ovs installation will depend on the latest kernel and force users to switch to new kernel, I believe it nerver will be so popular in the industies.
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 0d03334..7d8a0f4 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -1006,7 +1006,11 @@ netdev_vxlan_create(struct netdev *netdev) nl_msg_put_string(&request, IFLA_IFNAME, name); nl_msg_put_u32(&request, IFLA_MTU, UINT16_MAX); linkinfo_off = nl_msg_start_nested(&request, IFLA_LINKINFO); +#ifdef USE_UPSTREAM_TUNNEL nl_msg_put_string(&request, IFLA_INFO_KIND, "vxlan"); +#else + nl_msg_put_string(&request, IFLA_INFO_KIND, "ovs_vxlan"); +#endif infodata_off = nl_msg_start_nested(&request, IFLA_INFO_DATA); nl_msg_put_u8(&request, IFLA_VXLAN_LEARNING, 0); nl_msg_put_u8(&request, IFLA_VXLAN_COLLECT_METADATA, 1);