| Message ID | 1481140097-32096-3-git-send-email-alistair.francis@xilinx.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Wed, 7 Dec 2016 11:48:17 -0800, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> What is this patch fixing? The commit log shouldn't be empty. Is this fixing an autobuilder issue? If so, there should be a reference to it. > --- > ...-Disable-strtict-unused-const-variable-ch.patch | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch > > diff --git a/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch > new file mode 100644 > index 0000000..2bca456 > --- /dev/null > +++ b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch > @@ -0,0 +1,27 @@ > +From 3215099e9db9716dfade78880adb169bd7866192 Mon Sep 17 00:00:00 2001 > +From: Alistair Francis <alistair.francis@xilinx.com> > +Date: Wed, 7 Dec 2016 11:35:10 -0800 > +Subject: [PATCH] tools/libxl: Disable strtict unused-const-variable checking Typo in the tittle: strtict -> strict. Thomas
On Wed, Dec 7, 2016 at 12:50 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 7 Dec 2016 11:48:17 -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > > What is this patch fixing? The commit log shouldn't be empty. > > Is this fixing an autobuilder issue? If so, there should be a reference > to it. It is fixing an autobuilder issue, I have added a commit message with more details. > >> --- >> ...-Disable-strtict-unused-const-variable-ch.patch | 27 ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch >> >> diff --git a/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch >> new file mode 100644 >> index 0000000..2bca456 >> --- /dev/null >> +++ b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch >> @@ -0,0 +1,27 @@ >> +From 3215099e9db9716dfade78880adb169bd7866192 Mon Sep 17 00:00:00 2001 >> +From: Alistair Francis <alistair.francis@xilinx.com> >> +Date: Wed, 7 Dec 2016 11:35:10 -0800 >> +Subject: [PATCH] tools/libxl: Disable strtict unused-const-variable checking > > Typo in the tittle: strtict -> strict. Good catch, fixed in v2. Thanks, Alistair > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hello, On Wed, 7 Dec 2016 15:39:26 -0800, Alistair Francis wrote: > > > > What is this patch fixing? The commit log shouldn't be empty. > > > > Is this fixing an autobuilder issue? If so, there should be a reference > > to it. > > It is fixing an autobuilder issue, I have added a commit message with > more details. Good, but you still forgot (in your v2) a link to the autobuilder issue being fixed. See https://git.buildroot.org/buildroot/commit/?id=041c717ec8c251b7bca675086510840f02274967 for an example of how we reference autobuilder issues. Thanks! Thomas
On Thu, Dec 8, 2016 at 12:31 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 7 Dec 2016 15:39:26 -0800, Alistair Francis wrote: > >> > >> > What is this patch fixing? The commit log shouldn't be empty. >> > >> > Is this fixing an autobuilder issue? If so, there should be a reference >> > to it. >> >> It is fixing an autobuilder issue, I have added a commit message with >> more details. > > Good, but you still forgot (in your v2) a link to the autobuilder issue > being fixed. See > https://git.buildroot.org/buildroot/commit/?id=041c717ec8c251b7bca675086510840f02274967 > for an example of how we reference autobuilder issues. Thanks for the example. I am sending a V3 with the autobuilder issue referenced. Thanks, Alistair > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch new file mode 100644 index 0000000..2bca456 --- /dev/null +++ b/package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch @@ -0,0 +1,27 @@ +From 3215099e9db9716dfade78880adb169bd7866192 Mon Sep 17 00:00:00 2001 +From: Alistair Francis <alistair.francis@xilinx.com> +Date: Wed, 7 Dec 2016 11:35:10 -0800 +Subject: [PATCH] tools/libxl: Disable strtict unused-const-variable checking + +Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> +--- + tools/libxl/Makefile | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile +index defeb40..9d320d1 100644 +--- a/tools/libxl/Makefile ++++ b/tools/libxl/Makefile +@@ -12,7 +12,8 @@ XLUMAJOR = 4.7 + XLUMINOR = 0 + + CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \ +- -Wno-declaration-after-statement -Wformat-nonliteral ++ -Wno-declaration-after-statement -Wformat-nonliteral \ ++ -Werror=unused-const-variable=0 + CFLAGS += -I. -fPIC + + ifeq ($(CONFIG_Linux),y) +-- +2.7.4 +
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- ...-Disable-strtict-unused-const-variable-ch.patch | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/xen/0003-tools-libxl-Disable-strtict-unused-const-variable-ch.patch