| Message ID | 20161206171714.22738-2-zajec5@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 12/6/2016 9:17 AM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > There are 3 separated controllers, one per USB /standard/. With PHY > drivers in place they can be simply supported with generic drivers. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index f09a2bb..bfc98d19 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -248,8 +248,26 @@ > > #address-cells = <1>; > #size-cells = <1>; > + ranges; > > - phys = <&usb2_phy>; > + interrupt-parent = <&gic>; > + > + ohci: ohci@21000 { > + #usb-cells = <0>; > + > + compatible = "generic-ohci"; > + reg = <0x00022000 0x1000>; Your label ohci@21000 does not match the 'reg' at 0x22000. > + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + ehci: ehci@22000 { > + #usb-cells = <0>; > + > + compatible = "generic-ehci"; > + reg = <0x00021000 0x1000>; Looks like you got the label of ohci and ehci reversed? > + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; > + phys = <&usb2_phy>; > + }; > }; > > usb3: usb3@23000 { > @@ -257,6 +275,19 @@ > > #address-cells = <1>; > #size-cells = <1>; > + ranges; > + > + interrupt-parent = <&gic>; > + > + xhci: xhci@23000 { > + #usb-cells = <0>; > + > + compatible = "generic-xhci"; > + reg = <0x00023000 0x1000>; > + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; > + phys = <&usb3_phy>; > + phy-names = "usb"; > + }; > }; > > spi@29000 { >
On 6 December 2016 at 18:28, Ray Jui <ray.jui@broadcom.com> wrote: > On 12/6/2016 9:17 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> There are 3 separated controllers, one per USB /standard/. With PHY >> drivers in place they can be simply supported with generic drivers. >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >> --- >> arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- >> 1 file changed, 32 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >> index f09a2bb..bfc98d19 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -248,8 +248,26 @@ >> >> #address-cells = <1>; >> #size-cells = <1>; >> + ranges; >> >> - phys = <&usb2_phy>; >> + interrupt-parent = <&gic>; >> + >> + ohci: ohci@21000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ohci"; >> + reg = <0x00022000 0x1000>; > > Your label ohci@21000 does not match the 'reg' at 0x22000. > >> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + >> + ehci: ehci@22000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ehci"; >> + reg = <0x00021000 0x1000>; > > Looks like you got the label of ohci and ehci reversed? Nice catch, thanks! I'll fix it in V2 (just let me wait a day to see if there will be other comments).
On 12/6/2016 9:31 AM, Rafał Miłecki wrote: > On 6 December 2016 at 18:28, Ray Jui <ray.jui@broadcom.com> wrote: >> On 12/6/2016 9:17 AM, Rafał Miłecki wrote: >>> From: Rafał Miłecki <rafal@milecki.pl> >>> >>> There are 3 separated controllers, one per USB /standard/. With PHY >>> drivers in place they can be simply supported with generic drivers. >>> >>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >>> --- >>> arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- >>> 1 file changed, 32 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >>> index f09a2bb..bfc98d19 100644 >>> --- a/arch/arm/boot/dts/bcm5301x.dtsi >>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >>> @@ -248,8 +248,26 @@ >>> >>> #address-cells = <1>; >>> #size-cells = <1>; >>> + ranges; >>> >>> - phys = <&usb2_phy>; >>> + interrupt-parent = <&gic>; >>> + >>> + ohci: ohci@21000 { >>> + #usb-cells = <0>; >>> + >>> + compatible = "generic-ohci"; >>> + reg = <0x00022000 0x1000>; >> >> Your label ohci@21000 does not match the 'reg' at 0x22000. >> >>> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; >>> + }; >>> + >>> + ehci: ehci@22000 { >>> + #usb-cells = <0>; >>> + >>> + compatible = "generic-ehci"; >>> + reg = <0x00021000 0x1000>; >> >> Looks like you got the label of ohci and ehci reversed? > > Nice catch, thanks! I'll fix it in V2 (just let me wait a day to see > if there will be other comments). > In V2, please remember to put the nodes in ascending order based on the base address of the registers, i.e., ehci@21000, and then followed by ohci@22000. Thanks, Ray
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi index f09a2bb..bfc98d19 100644 --- a/arch/arm/boot/dts/bcm5301x.dtsi +++ b/arch/arm/boot/dts/bcm5301x.dtsi @@ -248,8 +248,26 @@ #address-cells = <1>; #size-cells = <1>; + ranges; - phys = <&usb2_phy>; + interrupt-parent = <&gic>; + + ohci: ohci@21000 { + #usb-cells = <0>; + + compatible = "generic-ohci"; + reg = <0x00022000 0x1000>; + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; + }; + + ehci: ehci@22000 { + #usb-cells = <0>; + + compatible = "generic-ehci"; + reg = <0x00021000 0x1000>; + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; + phys = <&usb2_phy>; + }; }; usb3: usb3@23000 { @@ -257,6 +275,19 @@ #address-cells = <1>; #size-cells = <1>; + ranges; + + interrupt-parent = <&gic>; + + xhci: xhci@23000 { + #usb-cells = <0>; + + compatible = "generic-xhci"; + reg = <0x00023000 0x1000>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; + phys = <&usb3_phy>; + phy-names = "usb"; + }; }; spi@29000 {