| Message ID | 1481038106-24899-8-git-send-email-mst@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 2016年12月06日 23:40, Michael S. Tsirkin wrote: > guest cid is read from config space, therefore it's in little endian > format and is treated as such, annotate it accordingly. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > net/vmw_vsock/virtio_transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > index 936d7ee..90096b9 100644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk) > static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock) > { > struct virtio_device *vdev = vsock->vdev; > - u64 guest_cid; > + __le64 guest_cid; > > vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid), > &guest_cid, sizeof(guest_cid)); Reviewed-by: Jason Wang <jasowang@redhat.com>
On Tue, Dec 06, 2016 at 05:40:57PM +0200, Michael S. Tsirkin wrote: > guest cid is read from config space, therefore it's in little endian > format and is treated as such, annotate it accordingly. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > net/vmw_vsock/virtio_transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 936d7ee..90096b9 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk) static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock) { struct virtio_device *vdev = vsock->vdev; - u64 guest_cid; + __le64 guest_cid; vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid), &guest_cid, sizeof(guest_cid));
guest cid is read from config space, therefore it's in little endian format and is treated as such, annotate it accordingly. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- net/vmw_vsock/virtio_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)