| Message ID | 20161206025321.1792-7-andrew@aj.id.au |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > The use of syscons is growing, lets collate them in their own part of > the bindings tree. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0 > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0 > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0 > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0 > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0 > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0 > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0 > 7 files changed, 0 insertions(+), 0 deletions(-) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%) > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%) I'm not so sure this is the right direction. syscon usage is pretty much spread throughout the tree. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > The use of syscons is growing, lets collate them in their own part of > > the bindings tree. > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > --- > > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0 > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0 > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0 > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0 > > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0 > > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0 > > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0 > > 7 files changed, 0 insertions(+), 0 deletions(-) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%) > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%) > > I'm not so sure this is the right direction. syscon usage is pretty much > spread throughout the tree. This patch was created based on my interpretation of Lee's feedback here: https://lkml.org/lkml/2016/11/18/650 Lee's next email in the chain poked Arnd for an opinion, but Arnd didn't reply. I don't mind. I moved these bindings separately so we could just drop the patch if there was push-back. If we drop the whole idea I'll need to apply a small fix to patch 5/6 to avoid creating the syscon subdirectory. Andrew > > Rob
On Tue, 13 Dec 2016, Andrew Jeffery wrote: > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > The use of syscons is growing, lets collate them in their own part of > > > the bindings tree. > > > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > --- > > > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0 > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0 > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0 > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0 > > > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0 > > > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0 > > > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0 > > > 7 files changed, 0 insertions(+), 0 deletions(-) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%) > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%) > > > > I'm not so sure this is the right direction. syscon usage is pretty much > > spread throughout the tree. > > This patch was created based on my interpretation of Lee's feedback > here: > > https://lkml.org/lkml/2016/11/18/650 > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > didn't reply. > > I don't mind. I moved these bindings separately so we could just drop > the patch if there was push-back. If we drop the whole idea I'll need > to apply a small fix to patch 5/6 to avoid creating the syscon > subdirectory. The sub-directory is a good idea for drivers who are *solely* syscon based.
On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote: > On Tue, 13 Dec 2016, Andrew Jeffery wrote: > > > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > > The use of syscons is growing, lets collate them in their own part of > > > > the bindings tree. > > > > > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > > > > > --- > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0 > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0 > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0 > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0 > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0 > > > > Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0 > > > > .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0 > > > > 7 files changed, 0 insertions(+), 0 deletions(-) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%) > > > > rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%) > > > > > > I'm not so sure this is the right direction. syscon usage is pretty much > > > spread throughout the tree. > > > > This patch was created based on my interpretation of Lee's feedback > > here: > > > > https://lkml.org/lkml/2016/11/18/650 > > > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > > didn't reply. > > > > I don't mind. I moved these bindings separately so we could just drop > > the patch if there was push-back. If we drop the whole idea I'll need > > to apply a small fix to patch 5/6 to avoid creating the syscon > > subdirectory. > > The sub-directory is a good idea for drivers who are *solely* syscon > based. > Yes, I wasn't saying otherwise, just commenting on my motivation and approach. As far as I can tell all of the bindings I move here describe solely syscon-based devices. Cheers, Andrew
On Tuesday, December 13, 2016 10:35:34 PM CET Andrew Jeffery wrote: > On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote: > > On Tue, 13 Dec 2016, Andrew Jeffery wrote: > > > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > > > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > > > didn't reply. > > > > > > I don't mind. I moved these bindings separately so we could just drop > > > the patch if there was push-back. If we drop the whole idea I'll need > > > to apply a small fix to patch 5/6 to avoid creating the syscon > > > subdirectory. > > > > The sub-directory is a good idea for drivers who are *solely* syscon > > based. > > > > Yes, I wasn't saying otherwise, just commenting on my motivation and > approach. > > As far as I can tell all of the bindings I move here describe solely > syscon-based devices. > But do we know which ones they are? In principle, any syscon device node can have a specialized driver exporting an interface, the bindings always allow it to be done one way or the other, and we may change the driver or run a different OS that has decided differently. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-12-13 at 13:17 +0100, Arnd Bergmann wrote: > On Tuesday, December 13, 2016 10:35:34 PM CET Andrew Jeffery wrote: > > On Tue, 2016-12-13 at 11:07 +0000, Lee Jones wrote: > > > On Tue, 13 Dec 2016, Andrew Jeffery wrote: > > > > On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote: > > > > > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote: > > > > > > > > Lee's next email in the chain poked Arnd for an opinion, but Arnd > > > > didn't reply. > > > > > > > > I don't mind. I moved these bindings separately so we could just drop > > > > the patch if there was push-back. If we drop the whole idea I'll need > > > > to apply a small fix to patch 5/6 to avoid creating the syscon > > > > subdirectory. > > > > > > The sub-directory is a good idea for drivers who are *solely* syscon > > > based. > > > > > > > Yes, I wasn't saying otherwise, just commenting on my motivation and > > approach. > > > > As far as I can tell all of the bindings I move here describe solely > > syscon-based devices. > > > > But do we know which ones they are? > > In principle, any syscon device node can have a specialized driver > exporting an interface, the bindings always allow it to be done > one way or the other, and we may change the driver or run a different > OS that has decided differently. > Right; for the Linux case there are currently no driver implementations that match on the compatible strings in the documents I moved (save for qcom,tcsr, except that it's the qcom,gsbi compatible driver parsing a phandle to the qcom,tcsr syscon node). However, I can't guarantee the solely-syscon property for other operating systems. Given that, it now looks to me like we shouldn't have such a directory at all. Cheers, Andrew
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/syscon/aspeed-scu.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/aspeed-scu.txt rename to Documentation/devicetree/bindings/mfd/syscon/aspeed-scu.txt diff --git a/Documentation/devicetree/bindings/mfd/atmel-gpbr.txt b/Documentation/devicetree/bindings/mfd/syscon/atmel-gpbr.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/atmel-gpbr.txt rename to Documentation/devicetree/bindings/mfd/syscon/atmel-gpbr.txt diff --git a/Documentation/devicetree/bindings/mfd/atmel-matrix.txt b/Documentation/devicetree/bindings/mfd/syscon/atmel-matrix.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/atmel-matrix.txt rename to Documentation/devicetree/bindings/mfd/syscon/atmel-matrix.txt diff --git a/Documentation/devicetree/bindings/mfd/atmel-smc.txt b/Documentation/devicetree/bindings/mfd/syscon/atmel-smc.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/atmel-smc.txt rename to Documentation/devicetree/bindings/mfd/syscon/atmel-smc.txt diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.txt b/Documentation/devicetree/bindings/mfd/syscon/qcom,tcsr.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/qcom,tcsr.txt rename to Documentation/devicetree/bindings/mfd/syscon/qcom,tcsr.txt diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon/syscon.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/syscon.txt rename to Documentation/devicetree/bindings/mfd/syscon/syscon.txt diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/syscon/ti-keystone-devctrl.txt similarity index 100% rename from Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt rename to Documentation/devicetree/bindings/mfd/syscon/ti-keystone-devctrl.txt
The use of syscons is growing, lets collate them in their own part of the bindings tree. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt | 0 Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt | 0 Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt | 0 Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt | 0 Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt | 0 Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt | 0 .../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt | 0 7 files changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%) rename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)