| Message ID | 1480978860-4351-11-git-send-email-jagan@openedev.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
Hello Jagan, Am 06.12.2016 um 00:00 schrieb Jagan Teki: > From: Jagan Teki <jteki@openedev.com> > > Added kconfig for SYS_I2C_MXC driver. > > Cc: Stefano Babic <sbabic@denx.de> > Cc: Heiko Schocher <hs@denx.de> > Cc: Matteo Lisi <matteo.lisi@engicam.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/i2c/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index 1537b67..051f911 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -109,6 +109,14 @@ config SYS_I2C_INTEL > the I2C API meaning that any I2C operations will immediately fail > for now. > > +config SYS_I2C_MXC > + bool "NXP i.MX I2C driver" > + depends on MX6 > + help > + Add support for the NXP i.MX I2C driver. This supports upto for bus > + channels and operating on standard mode upto 100 kbits/s and fast > + mode upto 400 kbits/s. > + > config SYS_I2C_ROCKCHIP > bool "Rockchip I2C driver" > depends on DM_I2C > I miss here junks, which move this symbol from the board config file into their defconfig file ... Can you add this please? You can use the great script from Masahiro for this task: tools/moveconfig.py bye, Heiko
On Mon, Dec 5, 2016 at 9:00 PM, Jagan Teki <jagan@openedev.com> wrote: > +config SYS_I2C_MXC > + bool "NXP i.MX I2C driver" > + depends on MX6 This driver is used among several i.MX SoC, so it would be better not to restrict it to MX6 only.
On Tue, Dec 6, 2016 at 3:47 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Mon, Dec 5, 2016 at 9:00 PM, Jagan Teki <jagan@openedev.com> wrote: > >> +config SYS_I2C_MXC >> + bool "NXP i.MX I2C driver" >> + depends on MX6 > > This driver is used among several i.MX SoC, so it would be better not > to restrict it to MX6 only. True, but the icorem6 is MX6 only so, the rest will ||ed while moving respective CONFIG_ to defconfig files thanks!
On Tue, Dec 6, 2016 at 3:06 PM, Heiko Schocher <hs@denx.de> wrote: > Hello Jagan, > > > Am 06.12.2016 um 00:00 schrieb Jagan Teki: >> >> From: Jagan Teki <jteki@openedev.com> >> >> Added kconfig for SYS_I2C_MXC driver. >> >> Cc: Stefano Babic <sbabic@denx.de> >> Cc: Heiko Schocher <hs@denx.de> >> Cc: Matteo Lisi <matteo.lisi@engicam.com> >> Cc: Michael Trimarchi <michael@amarulasolutions.com> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> drivers/i2c/Kconfig | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >> index 1537b67..051f911 100644 >> --- a/drivers/i2c/Kconfig >> +++ b/drivers/i2c/Kconfig >> @@ -109,6 +109,14 @@ config SYS_I2C_INTEL >> the I2C API meaning that any I2C operations will immediately >> fail >> for now. >> >> +config SYS_I2C_MXC >> + bool "NXP i.MX I2C driver" >> + depends on MX6 >> + help >> + Add support for the NXP i.MX I2C driver. This supports upto for >> bus >> + channels and operating on standard mode upto 100 kbits/s and >> fast >> + mode upto 400 kbits/s. >> + >> config SYS_I2C_ROCKCHIP >> bool "Rockchip I2C driver" >> depends on DM_I2C >> > > I miss here junks, which move this symbol from the board config file > into their defconfig file ... Can you add this please? Yes I will add them in separate patch. thanks!
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index 1537b67..051f911 100644 --- a/drivers/i2c/Kconfig +++ b/drivers/i2c/Kconfig @@ -109,6 +109,14 @@ config SYS_I2C_INTEL the I2C API meaning that any I2C operations will immediately fail for now. +config SYS_I2C_MXC + bool "NXP i.MX I2C driver" + depends on MX6 + help + Add support for the NXP i.MX I2C driver. This supports upto for bus + channels and operating on standard mode upto 100 kbits/s and fast + mode upto 400 kbits/s. + config SYS_I2C_ROCKCHIP bool "Rockchip I2C driver" depends on DM_I2C