Patchwork PATCH RFA: Remove GTY descbits

login
register
mail settings
Submitter Ian Taylor
Date Nov. 5, 2010, 5:45 a.m.
Message ID <mcrsjzge32y.fsf@google.com>
Download mbox | patch
Permalink /patch/70242/
State New
Headers show

Comments

Ian Taylor - Nov. 5, 2010, 5:45 a.m.
The gengtype program ignores the descbits option.  This option is used
in exactly one place, tree.h for the symtab union.  The descbits option
has been there since GTY was introduced back in 2002, and even at the
time it was ignored.  I think it's time to just remove it.

Bootstrapped and tested on x86_64-unknown-linux-gnu.  OK for mainline?

Ian


2010-11-04  Ian Lance Taylor  <iant@google.com>

	* tree.h (struct tree_type): Don't use descbits in GTY
	annotation.
	* gengtype.c (walk_type): Don't recognize descbits option.
Laurynas Biveinis - Nov. 5, 2010, 6:07 a.m.
2010/11/5 Ian Lance Taylor <iant@google.com>:
>        * tree.h (struct tree_type): Don't use descbits in GTY
>        annotation.
>        * gengtype.c (walk_type): Don't recognize descbits option.

This is OK. Thanks,

Patch

Index: tree.h
===================================================================
--- tree.h	(revision 166338)
+++ tree.h	(working copy)
@@ -2336,8 +2336,7 @@  struct GTY(()) tree_type {
     int GTY ((tag ("0"))) address;
     const char * GTY ((tag ("1"))) pointer;
     struct die_struct * GTY ((tag ("2"))) die;
-  } GTY ((desc ("debug_hooks == &sdb_debug_hooks ? 1 : debug_hooks == &dwarf2_debug_hooks ? 2 : 0"),
-	  descbits ("2"))) symtab;
+  } GTY ((desc ("debug_hooks == &sdb_debug_hooks ? 1 : debug_hooks == &dwarf2_debug_hooks ? 2 : 0"))) symtab;
   tree name;
   tree minval;
   tree maxval;
Index: gengtype.c
===================================================================
--- gengtype.c	(revision 166338)
+++ gengtype.c	(working copy)
@@ -2164,8 +2164,6 @@  walk_type (type_p t, struct walk_type_da
       ;
     else if (strcmp (oo->name, "default") == 0)
       ;
-    else if (strcmp (oo->name, "descbits") == 0)
-      ;
     else if (strcmp (oo->name, "param_is") == 0)
       ;
     else if (strncmp (oo->name, "param", 5) == 0