From patchwork Fri Nov 5 04:35:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joern Rennecke X-Patchwork-Id: 70237 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EE8EBB7104 for ; Fri, 5 Nov 2010 15:35:39 +1100 (EST) Received: (qmail 2389 invoked by alias); 5 Nov 2010 04:35:37 -0000 Received: (qmail 2325 invoked by uid 22791); 5 Nov 2010 04:35:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, MIME_QP_LONG_LINE, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from c60.cesmail.net (HELO c60.cesmail.net) (216.154.195.49) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Nov 2010 04:35:30 +0000 Received: from unknown (HELO epsilon2) ([192.168.1.60]) by c60.cesmail.net with ESMTP; 05 Nov 2010 00:35:21 -0400 Received: from 89.241.157.248 ([89.241.157.248]) by webmail.spamcop.net (Horde MIME library) with HTTP; Fri, 05 Nov 2010 00:35:28 -0400 Message-ID: <20101105003528.oltnc7fncwo80c40-nzlynne@webmail.spamcop.net> Date: Fri, 05 Nov 2010 00:35:28 -0400 From: Joern Rennecke To: Paul Koning Cc: gcc-patches@gcc.gnu.org Subject: Re: RFA: Fix target/44750 References: <20101104142521.ez0mn1k80g4ococo-nzlynne@webmail.spamcop.net> <76BC23E8-E889-405A-9CBD-651F4D63A4B6@dell.com> In-Reply-To: <76BC23E8-E889-405A-9CBD-651F4D63A4B6@dell.com> MIME-Version: 1.0 User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Quoting Paul Koning : > Joern, > > I ran into a problem with this. Oops, while we can rely on a fairly recent version of GNU make, the same is not true of the bootstrap compiler. So there is still a good reason to stick to the *.o-warn mechanism. The attached patch makes use of this so that we use just -Wno-error, and only when we're actually using -Werror in the first place. OK to apply? 2010-11-05 Joern Rennecke PR target/44750 * config/pdp11/t-pdp11 (dwarf2out.o, java/constants.o): Undo last change. Set $@-warn.o to -Wno-error. Index: config/pdp11/t-pdp11 =================================================================== --- config/pdp11/t-pdp11 (revision 166331) +++ config/pdp11/t-pdp11 (working copy) @@ -39,8 +39,10 @@ MULTILIB_OPTIONS = msoft-float # DWARF_ARANGES_PAD_SIZE is 0, thus a loop in output_aranges that checks # (i < (unsigned) DWARF_ARANGES_PAD_SIZE) elicits a warning that the # comparison is always false. -dwarf2out.o: ALL_COMPILERFLAGS += -Wno-error=type-limits +# We could say "-Werror -Wno-error=type-limits", alas, not all supported +# gcc bootstrap compilers support the latter option. +dwarf2out.o-warn = -Wno-error # Likewise, java/constants.c:build_constants_constructor has a negative shift # count (in never-executed code) due to the small POINTER_SIZE. -java/constants.o: ALL_COMPILERFLAGS += -Wno-error +java/constants.o-warn = -Wno-error