| Message ID | 1480790161-8097-1-git-send-email-xiyou.wangcong@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, 2016-12-03 at 10:36 -0800, Cong Wang wrote: > Cc: Hadar Hen Zion <hadarh@mellanox.com> > Cc: Jiri Pirko <jiri@mellanox.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > --- > net/sched/act_mirred.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c > index bb09ba3..2d9fa6e 100644 > --- a/net/sched/act_mirred.c > +++ b/net/sched/act_mirred.c > @@ -321,7 +321,7 @@ static int tcf_mirred_device(const struct tc_action *a, struct net *net, > int ifindex = tcf_mirred_ifindex(a); > > *mirred_dev = __dev_get_by_index(net, ifindex); > - if (!mirred_dev) > + if (!*mirred_dev) > return -EINVAL; > return 0; > } Fixes: 255cb30425c0 ("net/sched: act_mirred: Add new tc_action_ops get_dev()") Acked-by: Eric Dumazet <edumazet@google.com>
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Sat, 03 Dec 2016 10:59:18 -0800 > On Sat, 2016-12-03 at 10:36 -0800, Cong Wang wrote: >> Cc: Hadar Hen Zion <hadarh@mellanox.com> >> Cc: Jiri Pirko <jiri@mellanox.com> >> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> >> --- >> net/sched/act_mirred.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c >> index bb09ba3..2d9fa6e 100644 >> --- a/net/sched/act_mirred.c >> +++ b/net/sched/act_mirred.c >> @@ -321,7 +321,7 @@ static int tcf_mirred_device(const struct tc_action *a, struct net *net, >> int ifindex = tcf_mirred_ifindex(a); >> >> *mirred_dev = __dev_get_by_index(net, ifindex); >> - if (!mirred_dev) >> + if (!*mirred_dev) >> return -EINVAL; >> return 0; >> } > > Fixes: 255cb30425c0 ("net/sched: act_mirred: Add new tc_action_ops get_dev()") > Acked-by: Eric Dumazet <edumazet@google.com> Applied.
On 12/3/2016 8:36 PM, Cong Wang wrote: > Cc: Hadar Hen Zion <hadarh@mellanox.com> > Cc: Jiri Pirko <jiri@mellanox.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > --- > net/sched/act_mirred.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c > index bb09ba3..2d9fa6e 100644 > --- a/net/sched/act_mirred.c > +++ b/net/sched/act_mirred.c > @@ -321,7 +321,7 @@ static int tcf_mirred_device(const struct tc_action *a, struct net *net, > int ifindex = tcf_mirred_ifindex(a); > > *mirred_dev = __dev_get_by_index(net, ifindex); > - if (!mirred_dev) > + if (!*mirred_dev) > return -EINVAL; > return 0; > } Thank you for this fix! good catch. I know it's already applied. Hadar
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index bb09ba3..2d9fa6e 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred.c @@ -321,7 +321,7 @@ static int tcf_mirred_device(const struct tc_action *a, struct net *net, int ifindex = tcf_mirred_ifindex(a); *mirred_dev = __dev_get_by_index(net, ifindex); - if (!mirred_dev) + if (!*mirred_dev) return -EINVAL; return 0; }
Cc: Hadar Hen Zion <hadarh@mellanox.com> Cc: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> --- net/sched/act_mirred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)