| Message ID | 1480687801-19525-4-git-send-email-amelie.delaunay@st.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Hi, On 02/12/2016 at 15:09:55 +0100, Amelie Delaunay wrote : > This patch adds documentation of device tree bindings for the STM32 RTC. > > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > .../devicetree/bindings/rtc/st,stm32-rtc.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > > diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > new file mode 100644 > index 0000000..4578838 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt > @@ -0,0 +1,31 @@ > +STM32 Real Time Clock > + > +Required properties: > +- compatible: "st,stm32-rtc". > +- reg: address range of rtc register set. > +- clocks: reference to the clock entry ck_rtc. > +- clock-names: name of the clock used. Should be "ck_rtc". Is this name really useful? > +- interrupt-parent: phandle for the interrupt controller. > +- interrupts: rtc alarm interrupt. > +- interrupt-names: rtc alarm interrupt name, should be "alarm". Same comment, is this name really useful?
Hi Alexandre, Thanks for reviewing On 12/05/2016 11:06 AM, Alexandre Belloni wrote: > Hi, > > On 02/12/2016 at 15:09:55 +0100, Amelie Delaunay wrote : >> This patch adds documentation of device tree bindings for the STM32 RTC. >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> >> --- >> .../devicetree/bindings/rtc/st,stm32-rtc.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> new file mode 100644 >> index 0000000..4578838 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt >> @@ -0,0 +1,31 @@ >> +STM32 Real Time Clock >> + >> +Required properties: >> +- compatible: "st,stm32-rtc". >> +- reg: address range of rtc register set. >> +- clocks: reference to the clock entry ck_rtc. >> +- clock-names: name of the clock used. Should be "ck_rtc". > > Is this name really useful? You're right, not useful. > >> +- interrupt-parent: phandle for the interrupt controller. >> +- interrupts: rtc alarm interrupt. >> +- interrupt-names: rtc alarm interrupt name, should be "alarm". > > Same comment, is this name really useful? Ditto. > > Best regards, Amelie -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt new file mode 100644 index 0000000..4578838 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt @@ -0,0 +1,31 @@ +STM32 Real Time Clock + +Required properties: +- compatible: "st,stm32-rtc". +- reg: address range of rtc register set. +- clocks: reference to the clock entry ck_rtc. +- clock-names: name of the clock used. Should be "ck_rtc". +- interrupt-parent: phandle for the interrupt controller. +- interrupts: rtc alarm interrupt. +- interrupt-names: rtc alarm interrupt name, should be "alarm". +- st,syscfg: phandle for pwrcfg, mandatory to disable/enable backup domain + (RTC registers) write protection. + +Optional properties (to override default ck_rtc parent clock): +- assigned-clocks: reference to the ck_rtc clock entry. +- assigned-clock-parents: phandle of the new parent clock of ck_rtc. + +Example: + + rtc: rtc@40002800 { + compatible = "st,stm32-rtc"; + reg = <0x40002800 0x400>; + clocks = <&rcc 1 CLK_RTC>; + clock-names = "ck_rtc"; + assigned-clocks = <&rcc 1 CLK_RTC>; + assigned-clock-parents = <&rcc 1 CLK_LSE>; + interrupt-parent = <&exti>; + interrupts = <17 1>; + interrupt-names = "alarm"; + st,syscfg = <&pwrcfg>; + };
This patch adds documentation of device tree bindings for the STM32 RTC. Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> --- .../devicetree/bindings/rtc/st,stm32-rtc.txt | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/st,stm32-rtc.txt