| Message ID | f3d9a59a-5132-168f-86b3-206ed4781121@samsung.com |
|---|---|
| State | Accepted |
| Commit | c942fc925e7dabbba38ec58953455a0ecc3e6517 |
| Delegated to: | Jaehoon Chung |
| Headers | show |
On Fri, Dec 02, 2016 at 05:46:10PM +0900, Jaehoon Chung wrote: > Remove the entire spear_sdhci.c file. > There is no use case. This is dead codes. > Also there is no place to call "spear_sdhci_init()" anywhere. > > If some people use this file, let me know, plz. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> It looks like it was added as dead code so: Reviewed-by: Tom Rini <trini@konsulko.com>
On 12/02/2016 11:04 PM, Tom Rini wrote: > On Fri, Dec 02, 2016 at 05:46:10PM +0900, Jaehoon Chung wrote: > >> Remove the entire spear_sdhci.c file. >> There is no use case. This is dead codes. >> Also there is no place to call "spear_sdhci_init()" anywhere. >> >> If some people use this file, let me know, plz. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > > It looks like it was added as dead code so: > > Reviewed-by: Tom Rini <trini@konsulko.com> Applied on u-boot-mmc. Thanks! Best Regards, Jaehoon Chung >
diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile index d850758..94da954 100644 --- a/drivers/mmc/Makefile +++ b/drivers/mmc/Makefile @@ -52,7 +52,6 @@ obj-$(CONFIG_SDHCI) += sdhci.o obj-$(CONFIG_SH_MMCIF) += sh_mmcif.o obj-$(CONFIG_SH_SDHI) += sh_sdhi.o obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o -obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o obj-$(CONFIG_MMC_UNIPHIER) += uniphier-sd.o obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o diff --git a/drivers/mmc/spear_sdhci.c b/drivers/mmc/spear_sdhci.c deleted file mode 100644 index 06179cd..0000000 --- a/drivers/mmc/spear_sdhci.c +++ /dev/null @@ -1,27 +0,0 @@ -/* - * (C) Copyright 2012 - * Vipin Kumar, ST Micoelectronics, vipin.kumar@st.com. - * - * SPDX-License-Identifier: GPL-2.0+ - */ - -#include <common.h> -#include <malloc.h> -#include <sdhci.h> - -int spear_sdhci_init(u32 regbase, u32 max_clk, u32 min_clk, u32 quirks) -{ - struct sdhci_host *host = NULL; - host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host)); - if (!host) { - printf("sdhci host malloc fail!\n"); - return 1; - } - - host->name = "sdhci"; - host->ioaddr = (void *)regbase; - host->quirks = quirks; - - add_sdhci(host, max_clk, min_clk); - return 0; -}
Remove the entire spear_sdhci.c file. There is no use case. This is dead codes. Also there is no place to call "spear_sdhci_init()" anywhere. If some people use this file, let me know, plz. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/Makefile | 1 - drivers/mmc/spear_sdhci.c | 27 --------------------------- 2 files changed, 28 deletions(-) delete mode 100644 drivers/mmc/spear_sdhci.c