| Message ID | 20101104174704.573c52e4@s6510 |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <shemminger@vyatta.com> Date: Thu, 4 Nov 2010 17:47:04 -0400 > The basic classifier keeps statistics but does not report it to user space. > This showed up when using basic classifier (with police) as a default catch > all on ingress; no statistics were reported. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/sched/cls_basic.c 2010-11-04 16:06:19.984953193 -0400 +++ b/net/sched/cls_basic.c 2010-11-04 16:06:42.248953192 -0400 @@ -268,6 +268,10 @@ static int basic_dump(struct tcf_proto * goto nla_put_failure; nla_nest_end(skb, nest); + + if (tcf_exts_dump_stats(skb, &f->exts, &basic_ext_map) < 0) + goto nla_put_failure; + return skb->len; nla_put_failure:
The basic classifier keeps statistics but does not report it to user space. This showed up when using basic classifier (with police) as a default catch all on ingress; no statistics were reported. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- I consider this a bug and should go into net-2.6 but not stable. net/sched/cls_basic.c | 4 ++++ 1 file changed, 4 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html