diff mbox

[next,10/10] gstreamer1/gst1-imx: bump version to 0.12.3

Message ID 20161130112518.36300-10-Vincent.Riera@imgtec.com
State Accepted
Commit 4f29cc436b24a8007b065253babe27b9346a479e
Headers show

Commit Message

Vicente Olivert Riera Nov. 30, 2016, 11:25 a.m. UTC
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/gstreamer1/gst1-imx/gst1-imx.hash | 2 +-
 package/gstreamer1/gst1-imx/gst1-imx.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard Dec. 1, 2016, 10:20 p.m. UTC | #1
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
 > ---
 >  package/gstreamer1/gst1-imx/gst1-imx.hash | 2 +-
 >  package/gstreamer1/gst1-imx/gst1-imx.mk   | 2 +-
 >  2 files changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/package/gstreamer1/gst1-imx/gst1-imx.hash b/package/gstreamer1/gst1-imx/gst1-imx.hash
 > index d345deb..b0124aa 100644
 > --- a/package/gstreamer1/gst1-imx/gst1-imx.hash
 > +++ b/package/gstreamer1/gst1-imx/gst1-imx.hash
 > @@ -1,2 +1,2 @@
 >  # locally computed hash
 > -sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.2.tar.gz
 > +sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.3.tar.gz

Ehh, did you even test this?

You didn't update the hash to match the new tarball, and you also didn't
remove the now upstreamed patch.

I've pushed a fix for both issues, but please test your changes better
in the future.
Vicente Olivert Riera Dec. 2, 2016, 11:31 a.m. UTC | #2
Hi Peter,

On 01/12/16 22:20, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> 
>  > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>  > ---
>  >  package/gstreamer1/gst1-imx/gst1-imx.hash | 2 +-
>  >  package/gstreamer1/gst1-imx/gst1-imx.mk   | 2 +-
>  >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>  > diff --git a/package/gstreamer1/gst1-imx/gst1-imx.hash b/package/gstreamer1/gst1-imx/gst1-imx.hash
>  > index d345deb..b0124aa 100644
>  > --- a/package/gstreamer1/gst1-imx/gst1-imx.hash
>  > +++ b/package/gstreamer1/gst1-imx/gst1-imx.hash
>  > @@ -1,2 +1,2 @@
>  >  # locally computed hash
>  > -sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.2.tar.gz
>  > +sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.3.tar.gz
> 
> Ehh, did you even test this?

yes, I did a build test for the complete gstreamer1 (selecting all
packages).

> You didn't update the hash to match the new tarball, and you also didn't
> remove the now upstreamed patch.
> 
> I've pushed a fix for both issues, but please test your changes better
> in the future.

I probably made a mistake when creating the patches, but I did build
tested it.

I'll be more careful in the future. Sorry about that.

Vincent


>
diff mbox

Patch

diff --git a/package/gstreamer1/gst1-imx/gst1-imx.hash b/package/gstreamer1/gst1-imx/gst1-imx.hash
index d345deb..b0124aa 100644
--- a/package/gstreamer1/gst1-imx/gst1-imx.hash
+++ b/package/gstreamer1/gst1-imx/gst1-imx.hash
@@ -1,2 +1,2 @@ 
 # locally computed hash
-sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.2.tar.gz
+sha256 a75f8bc3219fa3c62637f443cef0196c9eafb90aaa5af094847d007124895822  gst1-imx-0.12.3.tar.gz
diff --git a/package/gstreamer1/gst1-imx/gst1-imx.mk b/package/gstreamer1/gst1-imx/gst1-imx.mk
index 3c6b1b6..71b4e1e 100644
--- a/package/gstreamer1/gst1-imx/gst1-imx.mk
+++ b/package/gstreamer1/gst1-imx/gst1-imx.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-GST1_IMX_VERSION = 0.12.2
+GST1_IMX_VERSION = 0.12.3
 GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
 
 GST1_IMX_LICENSE = LGPLv2+