| Message ID | 1480445612-6188-1-git-send-email-tiago.brusamarello@datacom.ind.br |
|---|---|
| State | Changes Requested |
| Headers | show |
On 29-11-16 19:53, Tiago Brusamarello wrote: > When generating the environment image the target endianess should > be taken in account for CRC calculation purposes. For big endian > targets the -b flag should be passed to the mkenvimage tool. > > Signed-off-by: Tiago Brusamarello <tiago.brusamarello@datacom.ind.br> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> though I do have two minor nits. > --- > boot/uboot/uboot.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk > index 3e347c1..17b80cc 100644 > --- a/boot/uboot/uboot.mk > +++ b/boot/uboot/uboot.mk > @@ -223,6 +223,7 @@ define UBOOT_INSTALL_IMAGES_CMDS > cat $(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE)) | \ > $(HOST_DIR)/usr/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \ > $(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \ > + $(if $(findstring "BIG", $(BR2_ENDIAN)),-b) \ ^we don't put spaces macro calls Also, we usually use 'filter' rather than 'findstring' to emulate an ifeq in $(if ...). Regards, Arnout > -o $(BINARIES_DIR)/uboot-env.bin -) > endef > >
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 3e347c1..17b80cc 100644 --- a/boot/uboot/uboot.mk +++ b/boot/uboot/uboot.mk @@ -223,6 +223,7 @@ define UBOOT_INSTALL_IMAGES_CMDS cat $(call qstrip,$(BR2_TARGET_UBOOT_ENVIMAGE_SOURCE)) | \ $(HOST_DIR)/usr/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \ $(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \ + $(if $(findstring "BIG", $(BR2_ENDIAN)),-b) \ -o $(BINARIES_DIR)/uboot-env.bin -) endef
When generating the environment image the target endianess should be taken in account for CRC calculation purposes. For big endian targets the -b flag should be passed to the mkenvimage tool. Signed-off-by: Tiago Brusamarello <tiago.brusamarello@datacom.ind.br> --- boot/uboot/uboot.mk | 1 + 1 file changed, 1 insertion(+)