diff mbox

rtc: ds1374: Merge conditional + WARN_ON()

Message ID 20161129110437epcms5p3214f832f54aedeed6d0d8e1c32109ce1@epcms5p3
State Accepted
Headers show

Commit Message

Srikant Ritolia Nov. 29, 2016, 11:04 a.m. UTC 
WARN_ON does both these things in one statement.
Using a better pattern with WARN_ON().

Signed-off-by: Srikant Ritolia <s.ritolia@samsung.com>
---
 drivers/rtc/rtc-ds1374.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Alexandre Belloni Dec. 7, 2016, 3:35 p.m. UTC | #1 
On 29/11/2016 at 11:04:37 +0000, Srikant Ritolia wrote :
> WARN_ON does both these things in one statement.
> Using a better pattern with WARN_ON().
> 
> Signed-off-by: Srikant Ritolia <s.ritolia@samsung.com>
> ---
>  drivers/rtc/rtc-ds1374.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
Applied, thanks.
diff mbox

Patch

diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index 3b3049c..52429f0 100644
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -89,10 +89,8 @@  static int ds1374_read_rtc(struct i2c_client *client, u32 *time,
 	int ret;
 	int i;
 
-	if (nbytes > 4) {
-		WARN_ON(1);
+	if (WARN_ON(nbytes > 4))
 		return -EINVAL;
-	}
 
 	ret = i2c_smbus_read_i2c_block_data(client, reg, nbytes, buf);