Message ID | 1479983568-4383-1-git-send-email-matwey@sai.msu.ru |
---|---|
State | Accepted |
Delegated to: | Jeff Kirsher |
Headers | show
Return-Path: <intel-wired-lan-bounces@lists.osuosl.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tSGxg4J81z9vDl for <incoming@patchwork.ozlabs.org>; Tue, 29 Nov 2016 06:31:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XbwmOaXY"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E1C552F54C; Mon, 28 Nov 2016 19:31:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-Zgzq8Qf5kN; Mon, 28 Nov 2016 19:30:59 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 890F7232AA; Mon, 28 Nov 2016 19:30:59 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 05F7D1BFB06 for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Nov 2016 10:33:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EDB8C23183 for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Nov 2016 10:33:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QcA9plBNze+Y for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Nov 2016 10:33:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by silver.osuosl.org (Postfix) with ESMTPS id E167223073 for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Nov 2016 10:33:08 +0000 (UTC) Received: by mail-lf0-f67.google.com with SMTP id p100so1674156lfg.2 for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Nov 2016 02:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=bJjLz3Sw8F9Vcx0jj9H/LayxdHoQYaAXP+yRcsG3Ro4=; b=XbwmOaXYtdb6rngfmC8heSRFJjMM4+JzpZh61AKz2fKrxxPdT/+OijlgYIOZIFGo/e qc1iED62dMOB444qAwfMyQd1SuB2N+IoZ8p268RxSjLy/mUwINSuDaxsoWeL94taMTD3 WhqBVRYGZHaX+HCGT8oZLrq6rKxC7N00HIrnzaBCxxySJEhMKAAldGXH4wCPjprbXoCR H/hCitTI4BOPvtmaWlhCdSNbpqVjon+/r5s72Iux5bKxeJu334a1ro9kvazPA7xWKPwe aHzTh1CDRBO+a0rJYc6Uh4YE2hrt1IdC3aLtf7fcYhrl4sdTdwjA5UPtpN9948jrIPWB VJ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=bJjLz3Sw8F9Vcx0jj9H/LayxdHoQYaAXP+yRcsG3Ro4=; b=ba2mgLtNNKBjw+duynqGWfbGzdfzLCRYwOFA4zxeWxdaOoETd0W2/wKjg8Dv2HUUGc oK72peUtkWv+bxaKhDKp5E0/lOos1e9UCqU13fqt84KPBoHBJ9m3Qfa8VWv1K65bkEzm 7l3DSAiZqygyjNNOfYD0DS1SXcQo3RCu/+ro3U0cmBzq7tTjwxdwwtNrE8L4uB7fQUpY /nF5H5Hx6t23azjc0HBglBn+AKY9GsTYXr9xhRl1RFTG7Tjz57MT/YjwhtQfEPOrZtVf KX9EY0GW12g+eYXC1cv9xt7Ivs70OOmmEwgKo2v07wMVLNn/3Jd/JmPT7g7nml7sldj6 2JtA== X-Gm-Message-State: AKaTC022KLGan1vlR0yXZV5Tj3jgJmWFegrr1WzouSmdeRX4uGizQDkPKPeu6UMfql0KhA== X-Received: by 10.25.199.145 with SMTP id x139mr588256lff.142.1479983586715; Thu, 24 Nov 2016 02:33:06 -0800 (PST) Received: from oak.local ([92.243.181.209]) by smtp.gmail.com with ESMTPSA id u74sm8120597lfi.9.2016.11.24.02.33.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Nov 2016 02:33:05 -0800 (PST) From: "Matwey V. Kornilov" <matwey@sai.msu.ru> To: jeffrey.t.kirsher@intel.com Date: Thu, 24 Nov 2016 13:32:48 +0300 Message-Id: <1479983568-4383-1-git-send-email-matwey@sai.msu.ru> X-Mailer: git-send-email 2.1.4 X-Mailman-Approved-At: Mon, 28 Nov 2016 19:30:58 +0000 Cc: "Matwey V. Kornilov" <matwey@sai.msu.ru>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, jcheung@suse.com, matwey.kornilov@gmail.com, intel-wired-lan@lists.osuosl.org, dchang@suse.com Subject: [Intel-wired-lan] [PATCH] igb: Explicitly select page 0 at initialization X-BeenThere: intel-wired-lan@lists.osuosl.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development <intel-wired-lan.lists.osuosl.org> List-Unsubscribe: <http://lists.osuosl.org/mailman/options/intel-wired-lan>, <mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe> List-Archive: <http://lists.osuosl.org/pipermail/intel-wired-lan/> List-Post: <mailto:intel-wired-lan@lists.osuosl.org> List-Help: <mailto:intel-wired-lan-request@lists.osuosl.org?subject=help> List-Subscribe: <http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, <mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@lists.osuosl.org Sender: "Intel-wired-lan" <intel-wired-lan-bounces@lists.osuosl.org> |
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index a61447f..1264a36 100644 --- a/drivers/net/ethernet/intel/igb/e1000_82575.c +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c @@ -246,6 +246,7 @@ static s32 igb_init_phy_params_82575(struct e1000_hw *hw) E1000_STATUS_FUNC_SHIFT; /* Set phy->phy_addr and phy->id. */ + igb_write_phy_reg_82580(hw, I347AT4_PAGE_SELECT, 0); ret_val = igb_get_phy_id_82575(hw); if (ret_val) return ret_val;
The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were removed in 2a3cdea) explicitly selected the required page at every phy_reg access. Currently, igb_get_phy_id_82575 relays on the fact that page 0 is already selected. The assumption is not fulfilled for my Lex 3I380CW motherboard with integrated dual i211 based gigabit ethernet. This leads to igb initialization failure and network interfaces are not working: igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k igb: Copyright (c) 2007-2014 Intel Corporation. igb: probe of 0000:01:00.0 failed with error -2 igb: probe of 0000:02:00.0 failed with error -2 In order to fix it, we explicitly select page 0 before first access to phy registers. See also: https://bugzilla.suse.com/show_bug.cgi?id=1009911 See also: http://www.lex.com.tw/products/pdf/3I380A&3I380CW.pdf Fixes: 2a3cdea ("igb: Remove GS40G specific defines/functions") Cc: <stable@vger.kernel.org> # 4.5+ Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> --- drivers/net/ethernet/intel/igb/e1000_82575.c | 1 + 1 file changed, 1 insertion(+)