| Message ID | 1288772847-8120-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Commit | 98aa1a65683efcece1d172a9c2649b5d1d149a19 |
| Headers | show |
most of these changes look sane ... i commented on the ones that i think need tweaking, but for the rest, Acked-by: Mike Frysinger <vapier@gentoo.org> -mike
On Wed, 2010-11-03 at 01:27 -0700, Brian Norris wrote: > We should allow the dump length to be 64-bit, especially since the value > was read in as a "long long" by strtoll(). > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > --- > nanddump.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/nanddump.c b/nanddump.c > index 86a71c9..fe29596 100644 > --- a/nanddump.c > +++ b/nanddump.c > @@ -83,7 +83,7 @@ static bool noecc = false; // don't error correct > static bool noskipbad = false; // don't skip bad blocks > static bool omitoob = false; // omit oob data > static unsigned long long start_addr; // start address > -static unsigned long length; // dump length > +static unsigned long long length; // dump length > static const char *mtddev; // mtd device name > static const char *dumpfile; // dump file name > static bool omitbad = false; This patch does not apply. Which version of MTD utils do you use? This change was done long time ago by the following commit: commit b16c1b630491a461b3ebb55d714d7bb0cd122737 Author: Grant Erickson <gerickson@nuovations.com> Date: Sun Sep 7 20:45:21 2008 +0000 nanddump: Qualifier Clean-up Static-qualified all globals except 'main' because they have no use beyond file scope. Constant-qualified MTD device and input positional parameter globals. Constant-qualified argv array. Signed-off-by: Grant Erickson <gerickson@nuovations.com> Acked-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Josh Boyer <jwboyer@gmail.com> Forgot to git-pull ? :-))))
On Sat, 2010-11-13 at 13:31 +0200, Artem Bityutskiy wrote:
> Forgot to git-pull ? :-))))
Brian, ignore this e-mail please :-) I've just pushed this patch,
thanks!
On Wed, 2010-11-03 at 01:27 -0700, Brian Norris wrote: > We should allow the dump length to be 64-bit, especially since the value > was read in as a "long long" by strtoll(). > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> I've pushed whole series, thanks a lot!
diff --git a/nanddump.c b/nanddump.c index 86a71c9..fe29596 100644 --- a/nanddump.c +++ b/nanddump.c @@ -83,7 +83,7 @@ static bool noecc = false; // don't error correct static bool noskipbad = false; // don't skip bad blocks static bool omitoob = false; // omit oob data static unsigned long long start_addr; // start address -static unsigned long length; // dump length +static unsigned long long length; // dump length static const char *mtddev; // mtd device name static const char *dumpfile; // dump file name static bool omitbad = false;
We should allow the dump length to be 64-bit, especially since the value was read in as a "long long" by strtoll(). Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- nanddump.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)