Patchwork Discussion about merging Go frontend

login
register
mail settings
Submitter Ian Taylor
Date Nov. 2, 2010, 5:59 p.m.
Message ID <mcr39rjvc7g.fsf@google.com>
Download mbox | patch
Permalink /patch/69914/
State New
Headers show

Comments

Ian Taylor - Nov. 2, 2010, 5:59 p.m.
"H.J. Lu" <hjl.tools@gmail.com> writes:

> This patch breaks gcc on Linux:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Sorry about that.  I did not test with the LTO plugin.

I have reverted the relevant portion of the patch, until Dave's patch
updating the lto plugin has been committed.

Ian


2010-11-02  Ian Lance Taylor  <iant@google.com>

	PR lto/46273
	* config.gcc: Revert last patch: set lto_binary_reader.
H.J. Lu - Nov. 2, 2010, 6 p.m.
On Tue, Nov 2, 2010 at 10:59 AM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> This patch breaks gcc on Linux:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273
>
> Sorry about that.  I did not test with the LTO plugin.
>
> I have reverted the relevant portion of the patch, until Dave's patch
> updating the lto plugin has been committed.
>
> Ian
>
>
> 2010-11-02  Ian Lance Taylor  <iant@google.com>
>
>        PR lto/46273
>        * config.gcc: Revert last patch: set lto_binary_reader.
>

Thanks.

Patch

Index: config.gcc
===================================================================
--- config.gcc	(revision 166189)
+++ config.gcc	(working copy)
@@ -219,6 +219,8 @@  default_gnu_indirect_function=no
 target_gtfiles=
 need_64bit_hwint=
 need_64bit_isa=
+# Selects the object file format reader/writer used by LTO.
+lto_binary_reader=lto-elf
 
 # Don't carry these over build->host->target.  Please.
 xm_file=
@@ -1158,11 +1160,13 @@  i[34567]86-*-darwin*)
 	# support.
 	with_cpu=${with_cpu:-generic}
 	tmake_file="${tmake_file} t-slibgcc-darwin i386/t-crtpc i386/t-crtfm"
+	lto_binary_reader=lto-macho
 	;;
 x86_64-*-darwin*)
 	with_cpu=${with_cpu:-generic}
 	tmake_file="${tmake_file} ${cpu_type}/t-darwin64 t-slibgcc-darwin i386/t-crtpc i386/t-crtfm"
 	tm_file="${tm_file} ${cpu_type}/darwin64.h"
+	lto_binary_reader=lto-macho
 	;;
 i[34567]86-*-elf*)
 	tm_file="${tm_file} i386/unix.h i386/att.h dbxelf.h elfos.h newlib-stdint.h i386/i386elf.h"
@@ -1417,6 +1421,7 @@  i[34567]86-*-pe | i[34567]86-*-cygwin*)
 		thread_file='posix'
 	fi
 	use_gcc_stdint=wrap
+	lto_binary_reader=lto-coff
 	;;
 i[34567]86-*-mingw* | x86_64-*-mingw*)
 	tm_file="${tm_file} i386/unix.h i386/bsd.h i386/gas.h dbxcoff.h i386/cygming.h i386/mingw32.h"
@@ -1489,6 +1494,7 @@  i[34567]86-*-mingw* | x86_64-*-mingw*)
 	cxx_target_objs="${cxx_target_objs} winnt-cxx.o msformat-c.o"
 	default_use_cxa_atexit=yes
 	use_gcc_stdint=wrap
+	lto_binary_reader=lto-coff
 	case ${enable_threads} in
 	  "" | yes | win32)	  thread_file='win32'
 	  tmake_file="${tmake_file} i386/t-gthr-win32"
@@ -2000,6 +2006,7 @@  powerpc-*-darwin*)
 	    ;;
 	esac
 	tmake_file="${tmake_file} t-slibgcc-darwin"
+	lto_binary_reader=lto-macho
 	extra_headers=altivec.h
 	;;
 powerpc64-*-darwin*)
@@ -2007,6 +2014,7 @@  powerpc64-*-darwin*)
 	extra_parts="crt2.o"
 	tmake_file="${tmake_file} ${cpu_type}/t-darwin64 t-slibgcc-darwin"
 	tm_file="${tm_file} ${cpu_type}/darwin8.h ${cpu_type}/darwin64.h"
+	lto_binary_reader=lto-macho
 	extra_headers=altivec.h
 	;;
 powerpc*-*-freebsd*)