Patchwork [testsuite,g++.dg] : Fix for PR target/28627

login
register
mail settings
Submitter Kai Tietz
Date Nov. 2, 2010, 12:26 p.m.
Message ID <OF916A42AA.19A4F96D-ONC12577CF.00439156-C12577CF.00443CD4@onevision.de>
Download mbox | patch
Permalink /patch/69877/
State New
Headers show

Comments

Kai Tietz - Nov. 2, 2010, 12:26 p.m.
Hello,

This patch adjusts the testcase by removing the second error-message, 
which isn't shown due early break on IPA passes on errors/sorries. For 
more details see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28627.

ChangeLog

2010-11-02  Kai Tietz

        PR/target 28627
        * g++.dg/ext/dllimport7.C: Adjust second error check and
        allow test for x86_64 mingw, too.

Tested for i686-pc-cygwin, i686-pc-mingw32, and x86_64-pc-mingw32. I will 
apply it tomorrow, if there are no objections.

Regards,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

 
@@ -19,13 +19,10 @@
 };
 
 const int Bar::three = 3;       //  { dg-warning "redeclared without 
dllimport" }
-//  { dg-error "definition of static data" "C++ specific error" { target 
i?86-*-cygwin* i?86-*-mingw* } 21 }
+//  { dg-error "definition of static data" "C++ specific error" { target 
i?86-*-cygwin* i?86-*-mingw* x86_64-*-mingw* } 21 }
 
 const Baz Bar::null_baz;       //  { dg-warning "redeclared without 
dllimport" }
-//  { dg-error "definition of static data" "C++ specific error" { target 
i?86-*-cygwin* i?86-*-mingw* }  24 }
 
-
-
 int foo()
 {
   Bar foobar;
Kai Tietz - Nov. 8, 2010, 10:51 a.m.
gcc-patches-owner@gcc.gnu.org wrote on 02.11.2010 13:26:09:

> Hello,
> 
> This patch adjusts the testcase by removing the second error-message, 
> which isn't shown due early break on IPA passes on errors/sorries. For 
> more details see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28627.
> 
> ChangeLog
> 
> 2010-11-02  Kai Tietz
> 
>         PR/target 28627
>         * g++.dg/ext/dllimport7.C: Adjust second error check and
>         allow test for x86_64 mingw, too.
> 
> Tested for i686-pc-cygwin, i686-pc-mingw32, and x86_64-pc-mingw32. I 
will 
> apply it tomorrow, if there are no objections.
> 
> Regards,
>  i.A. Kai Tietz
> 
> |  (\_/)  This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.
> 
> Index: dllimport7.C
> ===================================================================
> --- dllimport7.C        (revision 166174)
> +++ dllimport7.C        (working copy)
> @@ -1,4 +1,4 @@
> -// { dg-do compile { target i?86-*-cygwin* i?86-*-mingw*} }
> +// { dg-do compile { target i?86-*-cygwin* i?86-*-mingw* 
x86_64-*-mingw* 
> } }
> 
>  //  Report errors on definition of dllimport'd static data member . 
> 
> @@ -19,13 +19,10 @@
>  };
> 
>  const int Bar::three = 3;       //  { dg-warning "redeclared without 
> dllimport" }
> -//  { dg-error "definition of static data" "C++ specific error" { 
target 
> i?86-*-cygwin* i?86-*-mingw* } 21 }
> +//  { dg-error "definition of static data" "C++ specific error" { 
target 
> i?86-*-cygwin* i?86-*-mingw* x86_64-*-mingw* } 21 }
> 
>  const Baz Bar::null_baz;       //  { dg-warning "redeclared without 
> dllimport" }
> -//  { dg-error "definition of static data" "C++ specific error" { 
target 
> i?86-*-cygwin* i?86-*-mingw* }  24 }
> 
> -
> -
>  int foo()
>  {
>    Bar foobar;
> 

Applied at revision 166431.

Regards,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Patch

Index: dllimport7.C
===================================================================
--- dllimport7.C        (revision 166174)
+++ dllimport7.C        (working copy)
@@ -1,4 +1,4 @@ 
-// { dg-do compile { target i?86-*-cygwin* i?86-*-mingw*} }
+// { dg-do compile { target i?86-*-cygwin* i?86-*-mingw* x86_64-*-mingw* 
} }
 
 //  Report errors on definition of dllimport'd static data member .