Patchwork Fixed default IRQ assignment for PL190 VIC.

login
register
mail settings
Submitter Himanshu Chauhan
Date Nov. 1, 2010, 12:46 p.m.
Message ID <1288615561-16584-1-git-send-email-hschauhan@nulltrace.org>
Download mbox | patch
Permalink /patch/69768/
State New
Headers show

Comments

Himanshu Chauhan - Nov. 1, 2010, 12:46 p.m.
Everywhere else vect_addr[16] is returned on a read of default vector address
but updation is done only on default_addr in structure.

Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
---
 hw/pl190.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Aurelien Jarno - Dec. 27, 2010, 7:30 p.m.
On Mon, Nov 01, 2010 at 06:16:01PM +0530, Himanshu Chauhan wrote:
> Everywhere else vect_addr[16] is returned on a read of default vector address
> but updation is done only on default_addr in structure.
> 
> Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
> ---
>  hw/pl190.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pl190.c b/hw/pl190.c
> index a4bc9c1..7363b87 100644
> --- a/hw/pl190.c
> +++ b/hw/pl190.c
> @@ -187,6 +187,7 @@ static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
>          break;
>      case 13: /* DEFVECTADDR */
>          s->default_addr = val;
> +        s->vect_addr[16] = val;
>          break;
>      case 0xc0: /* ITCR */
>          if (val) {

After this change, default_addr is not used anymore in this file. It 
should be removed from the pl190_state structure.

Patch

diff --git a/hw/pl190.c b/hw/pl190.c
index a4bc9c1..7363b87 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -187,6 +187,7 @@  static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
         break;
     case 13: /* DEFVECTADDR */
         s->default_addr = val;
+        s->vect_addr[16] = val;
         break;
     case 0xc0: /* ITCR */
         if (val) {