Patchwork [RFC] xfail libstdc++-v3/testsuite/ext/profile/mh.cc for uclibc

login
register
mail settings
Submitter Jie Zhang
Date Nov. 1, 2010, 11:14 a.m.
Message ID <4CCEA11A.5010803@codesourcery.com>
Download mbox | patch
Permalink /patch/69757/
State New
Headers show

Comments

Jie Zhang - Nov. 1, 2010, 11:14 a.m.
Hi,

uClibc does not provide __malloc_hook. So that test should be xfailed 
for uclibc.  Is it OK?


Regards,
Jie Zhang - Nov. 15, 2010, 6:29 a.m.
Hi,

Can anyone give a review for this patch?

http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00027.html

Thanks!


Jie
Paolo Carlini - Nov. 15, 2010, 9:42 a.m.
On 11/15/2010 07:29 AM, Jie Zhang wrote:
> Hi,
>
> Can anyone give a review for this patch?
>
> http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00027.html
Patch is OK. In order to get the attention of the library maintainers I
suggest always CCing to libstdc++ too.

Thanks,
Paolo.
Jie Zhang - Nov. 15, 2010, 11:02 a.m.
On 11/15/2010 05:42 PM, Paolo Carlini wrote:
> On 11/15/2010 07:29 AM, Jie Zhang wrote:
>> Hi,
>>
>> Can anyone give a review for this patch?
>>
>> http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00027.html
> Patch is OK. In order to get the attention of the library maintainers I
> suggest always CCing to libstdc++ too.
>
Thanks! Committed now. I will next time.

Patch


	* testsuite/ext/profile/mh.cc: Add xfail for uclibc.

Index: testsuite/ext/profile/mh.cc
===================================================================
--- testsuite/ext/profile/mh.cc	(revision 166125)
+++ testsuite/ext/profile/mh.cc	(working copy)
@@ -1,5 +1,6 @@ 
 // { dg-options "-D_GLIBCXX_PROFILE" }
 // { dg-do compile { target *-*-linux* } }
+// { dg-xfail-if "" { uclibc } { "*" } { "" } }
 
 // -*- C++ -*-