Patchwork [RFC] Fix libstdc++ test fails with emutls

login
register
mail settings
Submitter Jie Zhang
Date Nov. 1, 2010, 9:18 a.m.
Message ID <4CCE85D8.3060107@codesourcery.com>
Download mbox | patch
Permalink /patch/69754/
State New
Headers show

Comments

Jie Zhang - Nov. 1, 2010, 9:18 a.m.
On 11/01/2010 03:48 PM, Jakub Jelinek wrote:
> On Mon, Nov 01, 2010 at 01:45:58PM +0800, Jie Zhang wrote:
>> mutex:704: undefined reference to `__emutls_v._ZSt15__once_callable'
>>
>> This patch should fix this error by exporting such like symbols.
>>
>> Is this patch OK?
>
> You shouldn't be exporting symbols that weren't (even by mistake) exported
> earlier in older symbol versions, always add new symbols to the latest
> version (GLIBCXX_3.4.15 right now).

Thanks for your review! How about this? I moved them to GLIBCXX_3.4.15 
and added a comment.


Regards,
Paolo Carlini - Nov. 1, 2010, 3:48 p.m.
On 11/01/2010 10:18 AM, Jie Zhang wrote:
> On 11/01/2010 03:48 PM, Jakub Jelinek wrote:
>> On Mon, Nov 01, 2010 at 01:45:58PM +0800, Jie Zhang wrote:
>>> mutex:704: undefined reference to `__emutls_v._ZSt15__once_callable'
>>>
>>> This patch should fix this error by exporting such like symbols.
>>>
>>> Is this patch OK?
>>
>> You shouldn't be exporting symbols that weren't (even by mistake)
>> exported
>> earlier in older symbol versions, always add new symbols to the latest
>> version (GLIBCXX_3.4.15 right now).
>
> Thanks for your review! How about this? I moved them to GLIBCXX_3.4.15
> and added a comment.
Ok.

Thanks,
Paolo.
Jie Zhang - Nov. 1, 2010, 3:59 p.m.
On 11/01/2010 11:48 PM, Paolo Carlini wrote:
> On 11/01/2010 10:18 AM, Jie Zhang wrote:
>> On 11/01/2010 03:48 PM, Jakub Jelinek wrote:
>>> On Mon, Nov 01, 2010 at 01:45:58PM +0800, Jie Zhang wrote:
>>>> mutex:704: undefined reference to `__emutls_v._ZSt15__once_callable'
>>>>
>>>> This patch should fix this error by exporting such like symbols.
>>>>
>>>> Is this patch OK?
>>>
>>> You shouldn't be exporting symbols that weren't (even by mistake)
>>> exported
>>> earlier in older symbol versions, always add new symbols to the latest
>>> version (GLIBCXX_3.4.15 right now).
>>
>> Thanks for your review! How about this? I moved them to GLIBCXX_3.4.15
>> and added a comment.
> Ok.
>
Committed on trunk. Thanks!

Patch


	* config/abi/pre/gnu.ver: Export __emutls_v._ZSt11__once_call
	and __emutls_v._ZSt15__once_callable.

Index: config/abi/pre/gnu.ver
===================================================================
--- config/abi/pre/gnu.ver	(revision 166125)
+++ config/abi/pre/gnu.ver	(working copy)
@@ -1187,6 +1187,10 @@ 
     # basic_filebuf::_M_get_ext_pos
     _ZNSt13basic_filebufI[cw]St11char_traitsI[cw]EE14_M_get_ext_pos*;
 
+    # targets using emutls
+    __emutls_v._ZSt11__once_call;
+    __emutls_v._ZSt15__once_callable;
+
 } GLIBCXX_3.4.14;
 
 # Symbols in the support library (libsupc++) have their own tag.