diff mbox

[testsuite] MIPS: Add isa>=2 option to interrupt_handler-bug-1.c.

Message ID A614194ED15B4844BC4C9FB7F21FCD92225342E7@HHMAIL01.hh.imgtec.org
State New
Headers show

Commit Message

Toma Tabacu Nov. 21, 2016, 1:52 p.m. UTC
Hi,

Currently, the interrupt_handler-bug-1.c test will fail on pre-R2 targets
because the "interrupt" function attribute requires at least an R2 target and
the test does not enforce this requirement.

This patch fixes this by adding the isa_rev>=2 option to the test's dg-options.

Tested with mips-mti-elf.

Regards,
Toma Tabacu

gcc/testsuite/ChangeLog:

2016-11-21  Toma Tabacu  <toma.tabacu@imgtec.com>

	* gcc.target/mips/interrupt_handler-bug-1.c (dg-options): Add
	isa_rev>=2.

Comments

Moore, Catherine Nov. 21, 2016, 9:28 p.m. UTC | #1
> -----Original Message-----
> From: Toma Tabacu [mailto:Toma.Tabacu@imgtec.com]
> Sent: Monday, November 21, 2016 8:53 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune <Matthew.Fortune@imgtec.com>; Moore,
> Catherine <Catherine_Moore@mentor.com>
> Subject: [PATCH, testsuite] MIPS: Add isa>=2 option to
> interrupt_handler-bug-1.c.
> 
> Hi,
> 
> Currently, the interrupt_handler-bug-1.c test will fail on pre-R2 targets
> because the "interrupt" function attribute requires at least an R2 target
> and
> the test does not enforce this requirement.
> 
> This patch fixes this by adding the isa_rev>=2 option to the test's dg-
> options.
> 
> Tested with mips-mti-elf.
> 
> Regards,
> Toma Tabacu
> 
> gcc/testsuite/ChangeLog:
> 
> 2016-11-21  Toma Tabacu  <toma.tabacu@imgtec.com>
> 
> 	* gcc.target/mips/interrupt_handler-bug-1.c (dg-options): Add
> 	isa_rev>=2.
> 

Yes, this is okay to commit.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
index 2784705..083e152 100644
--- a/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
+++ b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
@@ -1,4 +1,4 @@ 
-/* { dg-options "-funroll-loops" } */
+/* { dg-options "-funroll-loops isa_rev>=2" } */
 int foo;
 int bar;