| Message ID | 1479668387-6549-3-git-send-email-devpfl@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Pierre, Le 20/11/2016 à 19:59, pierre floury a écrit : > From: Romain Naour <romain.naour@gmail.com> > > This support is required for Enlightenment wayland support [1]. > > As stated in configure, Evas GL DRM Engine needs OpenGL ES with EGL and > wayland (wayland-client >= 1.8.0) > > [1] https://www.enlightenment.org/about-wayland > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Signed-off-by: Pierre Floury <devpfl@gmail.com> > > --- > v2: rename the option to BR2_PAKCAGE_EFL_GLES_DRM (ThomasP) > fix the help text (ThomasP) > --- > v3: rebase v2 on top of master > Signed-off-by: Pierre Floury <devpfl@gmail.com> As suggested by Thomas [1], enable gl-drm only if all dependencies are available without using another Kconfig symbol (BR2_PAKCAGE_EFL_GLES_DRM) This series is ok for me :) Best regards, Romain [1] http://lists.busybox.net/pipermail/buildroot/2016-September/172422.html > --- > package/efl/efl.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/efl/efl.mk b/package/efl/efl.mk > index d6b2bf5..fdeea47 100644 > --- a/package/efl/efl.mk > +++ b/package/efl/efl.mk > @@ -199,6 +199,12 @@ else > EFL_CONF_OPTS += --disable-drm > endif > > +ifeq ($(BR2_PACKAGE_EFL_OPENGLES)$(BR2_PACKAGE_EFL_DRM),yy) > +EFL_CONF_OPTS += --enable-gl-drm > +else > +EFL_CONF_OPTS += --disable-gl-drm > +endif > + > EFL_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBXKBCOMMON),libxkbcommon) > > # Loaders that need external dependencies needs to be --enable-XXX=yes >
Hi Pierre, Le 20/11/2016 à 20:30, Romain Naour a écrit : > Hi Pierre, > > Le 20/11/2016 à 19:59, pierre floury a écrit : >> From: Romain Naour <romain.naour@gmail.com> >> >> This support is required for Enlightenment wayland support [1]. >> >> As stated in configure, Evas GL DRM Engine needs OpenGL ES with EGL and >> wayland (wayland-client >= 1.8.0) ^^^^^^^ :) >> >> [1] https://www.enlightenment.org/about-wayland >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Signed-off-by: Pierre Floury <devpfl@gmail.com> >> >> --- >> v2: rename the option to BR2_PAKCAGE_EFL_GLES_DRM (ThomasP) >> fix the help text (ThomasP) >> --- >> v3: rebase v2 on top of master >> Signed-off-by: Pierre Floury <devpfl@gmail.com> > > As suggested by Thomas [1], enable gl-drm only if all dependencies are available > without using another Kconfig symbol (BR2_PAKCAGE_EFL_GLES_DRM) > > This series is ok for me :) Humm, I missed something in my initial patch... the Evas GL DRM doesn't build without Wayland package. From config.log: configure:42726: checking whether to enable OpenGL Drm rendering backend configure:42728: result: yes configure:42747: $PKG_CONFIG --exists --print-errors "egl ${gl_library} libdrm gbm wayland-client >= 1.11.0" Package wayland-client was not found in the pkg-config search path. Perhaps you should add the directory containing `wayland-client.pc' to the PKG_CONFIG_PATH environment variable Package 'wayland-client', required by 'world', not found configure:42750: $? = 1 configure:42875: error: OpenGL Drm dependencies not found In a previous local version I added a dependency to wayland to elput support but I finally dropped it in the final patch submission. I forgot to add it for the GL DRM support. I guess we should re-add BR2_PAKCAGE_EFL_GLES_DRM to define the wayland, efl-drm, opengl-es dependencies otherwise gl-drm would be enabled by: ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_EFL_OPENGLES)$(BR2_PACKAGE_EFL_DRM),yyy) EFL_CONF_OPTS += --enable-gl-drm else EFL_CONF_OPTS += --disable-gl-drm endif which is not really nice. I prefer: efl.mk: ifeq ($(BR2_PAKCAGE_EFL_GLES_DRM),y) EFL_CONF_OPTS += --enable-gl-drm else EFL_CONF_OPTS += --disable-gl-drm endif Config.in: config BR2_PAKCAGE_EFL_GLES_DRM bool "Evas GLES DRM Engine" depends on BR2_PACKAGE_EFL_DRM depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only depends on BR2_PACKAGE_WAYLAND help This option enable building support for the Evas DRM OpenGL ES based engine. comment "Evas GL DRM Engine needs Evas DRM Engine, OpenGL ES w/ EGL, Wayland" depends on BR2_PACKAGE_EFL_DRM && !BR2_PACKAGE_EFL_OPENGLES && !BR2_PACKAGE_WAYLAND Thoughts ? Best regards, Romain > > Best regards, > Romain > > [1] http://lists.busybox.net/pipermail/buildroot/2016-September/172422.html >> --- >> package/efl/efl.mk | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/package/efl/efl.mk b/package/efl/efl.mk >> index d6b2bf5..fdeea47 100644 >> --- a/package/efl/efl.mk >> +++ b/package/efl/efl.mk >> @@ -199,6 +199,12 @@ else >> EFL_CONF_OPTS += --disable-drm >> endif >> >> +ifeq ($(BR2_PACKAGE_EFL_OPENGLES)$(BR2_PACKAGE_EFL_DRM),yy) >> +EFL_CONF_OPTS += --enable-gl-drm >> +else >> +EFL_CONF_OPTS += --disable-gl-drm >> +endif >> + >> EFL_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBXKBCOMMON),libxkbcommon) >> >> # Loaders that need external dependencies needs to be --enable-XXX=yes >> >
diff --git a/package/efl/efl.mk b/package/efl/efl.mk index d6b2bf5..fdeea47 100644 --- a/package/efl/efl.mk +++ b/package/efl/efl.mk @@ -199,6 +199,12 @@ else EFL_CONF_OPTS += --disable-drm endif +ifeq ($(BR2_PACKAGE_EFL_OPENGLES)$(BR2_PACKAGE_EFL_DRM),yy) +EFL_CONF_OPTS += --enable-gl-drm +else +EFL_CONF_OPTS += --disable-gl-drm +endif + EFL_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBXKBCOMMON),libxkbcommon) # Loaders that need external dependencies needs to be --enable-XXX=yes