Patchwork PowerPC/Cell: use vzalloc rather than vmalloc and memset in spu_alloc_lscsa_std

login
register
mail settings
Submitter Jesper Juhl
Date Oct. 30, 2010, 6:10 p.m.
Message ID <alpine.LNX.2.00.1010302004290.1572@swampdragon.chaosbits.net>
Download mbox | patch
Permalink /patch/69694/
State Accepted
Commit 467d93a7ee64a5c8f675589d658ce3b8b502d288
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Jesper Juhl - Oct. 30, 2010, 6:10 p.m.
Hi,

We can get rid of a memset in 
arch/powerpc/platforms/cell/spufs/lscsa_alloc.c::spu_alloc_lscsa_std() by 
using vzalloc() rather than vmalloc()+memset().

Completely untested patch below since I have no hardware nor tools to 
compile this.


Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 lscsa_alloc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
index a101abf..3b894f5 100644
--- a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
+++ b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
@@ -36,10 +36,9 @@  static int spu_alloc_lscsa_std(struct spu_state *csa)
 	struct spu_lscsa *lscsa;
 	unsigned char *p;
 
-	lscsa = vmalloc(sizeof(struct spu_lscsa));
+	lscsa = vzalloc(sizeof(struct spu_lscsa));
 	if (!lscsa)
 		return -ENOMEM;
-	memset(lscsa, 0, sizeof(struct spu_lscsa));
 	csa->lscsa = lscsa;
 
 	/* Set LS pages reserved to allow for user-space mapping. */