Patchwork block: avoid a warning on 64 bit hosts with long as int64_t

login
register
mail settings
Submitter Blue Swirl
Date Oct. 30, 2010, 4:46 p.m.
Message ID <AANLkTikj-c7N2=sdSzwPqm0nDo35SNsSJ=5g8dU5Tr7g@mail.gmail.com>
Download mbox | patch
Permalink /patch/69665/
State New
Headers show

Comments

Blue Swirl - Oct. 30, 2010, 4:46 p.m.
When building on a 64 bit host which uses 'long' for int64_t,
GCC emits a warning:
  CC    block/blkverify.o
/src/qemu/block/blkverify.c: In function `blkverify_verify_readv':
/src/qemu/block/blkverify.c:304: warning: long long int format, long
unsigned int arg (arg 3)

Rework a77cffe7e916f4dd28f2048982ea2e0d98143b11 to avoid the warning.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 block/blkverify.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Kevin Wolf - Nov. 2, 2010, 3:05 p.m.
Am 30.10.2010 18:46, schrieb Blue Swirl:
> When building on a 64 bit host which uses 'long' for int64_t,
> GCC emits a warning:
>   CC    block/blkverify.o
> /src/qemu/block/blkverify.c: In function `blkverify_verify_readv':
> /src/qemu/block/blkverify.c:304: warning: long long int format, long
> unsigned int arg (arg 3)
> 
> Rework a77cffe7e916f4dd28f2048982ea2e0d98143b11 to avoid the warning.
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/block/blkverify.c b/block/blkverify.c
index b2a12fe..4d9ab6b 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -300,8 +300,8 @@  static void blkverify_verify_readv(BlkverifyAIOCB *acb)
 {
     ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov);
     if (offset != -1) {
-        blkverify_err(acb, "contents mismatch in sector %lld",
-                      acb->sector_num + (offset / BDRV_SECTOR_SIZE));
+        blkverify_err(acb, "contents mismatch in sector %" PRId64,
+                      acb->sector_num + (int64_t)(offset / BDRV_SECTOR_SIZE));
     }
 }