diff mbox

PR78319

Message ID CAAgBjM=h6mDnppMVQyCU21hufHYbTHFwFJxBkyQN8bZdWYPRgg@mail.gmail.com
State New
Headers show

Commit Message

Prathamesh Kulkarni Nov. 16, 2016, 8:23 p.m. UTC 
Hi,
As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi.
OK to commit ?

Thanks,
Prathamesh
2016-11-17  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>

	PR tree-optimization/78319

testsuite/
	* gcc.dg/uninit-pred-8_a.c (foo): Mark dg-bogus test to xfail on
	arm-none-eabi.

Comments

Jeff Law Nov. 16, 2016, 9:50 p.m. UTC | #1 
On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote:
> Hi,
> As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi.
> OK to commit ?
You might check if Aldy's change to the uninit code helps your case 
(approved earlier today, so hopefully in the tree very soon).  I quickly 
scanned the BZ.  There's some overlap, but it might be too complex for 
Aldy's enhancements to catch.

jeff
Prathamesh Kulkarni Nov. 17, 2016, 7:29 a.m. UTC | #2 
On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote:
> On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote:
>>
>> Hi,
>> As discussed in PR, this patch marks the test-case to xfail on
>> arm-none-eabi.
>> OK to commit ?
>
> You might check if Aldy's change to the uninit code helps your case
> (approved earlier today, so hopefully in the tree very soon).  I quickly
> scanned the BZ.  There's some overlap, but it might be too complex for
> Aldy's enhancements to catch.
Hi Jeff,
I tried Aldy's patch [1], but it didn't catch the case in PR78319.

[1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html

Thanks,
Prathamesh
>
> jeff
Richard Biener Nov. 17, 2016, 8:52 a.m. UTC | #3 
On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote:

> On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote:
> > On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote:
> >>
> >> Hi,
> >> As discussed in PR, this patch marks the test-case to xfail on
> >> arm-none-eabi.
> >> OK to commit ?
> >
> > You might check if Aldy's change to the uninit code helps your case
> > (approved earlier today, so hopefully in the tree very soon).  I quickly
> > scanned the BZ.  There's some overlap, but it might be too complex for
> > Aldy's enhancements to catch.
> Hi Jeff,
> I tried Aldy's patch [1], but it didn't catch the case in PR78319.
> 
> [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html

XFAILing is ok.

Richard.

> Thanks,
> Prathamesh
> >
> > jeff
> 
>
Jeff Law Nov. 17, 2016, 3:17 p.m. UTC | #4 
On 11/17/2016 01:52 AM, Richard Biener wrote:
> On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote:
>
>> On 17 November 2016 at 03:20, Jeff Law <law@redhat.com> wrote:
>>> On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote:
>>>>
>>>> Hi,
>>>> As discussed in PR, this patch marks the test-case to xfail on
>>>> arm-none-eabi.
>>>> OK to commit ?
>>>
>>> You might check if Aldy's change to the uninit code helps your case
>>> (approved earlier today, so hopefully in the tree very soon).  I quickly
>>> scanned the BZ.  There's some overlap, but it might be too complex for
>>> Aldy's enhancements to catch.
>> Hi Jeff,
>> I tried Aldy's patch [1], but it didn't catch the case in PR78319.
>>
>> [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00225.html
>
> XFAILing is ok.
Agreed.

Thanks for checking Prathamesh.

Jeff
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c
index 1b7c472..c45fba0 100644
--- a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c
+++ b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c
@@ -16,8 +16,9 @@  int foo (int n, int l, int m, int r)
   if (m) g++;
   else   bar();
 
+  /* marking this test as xfail on arm-none-eabi, see PR78319.  */
   if ( n ||  m || r || l)
-      blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */
+      blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail arm-none-eabi } } */
 
   if ( n )
       blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */