| Message ID | 1479268992-26811-9-git-send-email-jagan@openedev.com |
|---|---|
| State | Accepted |
| Commit | 8e492951a8b0e6fdfbf066c1d12e071a003879b7 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi, > -----Original Message----- > From: Jagan Teki [mailto:jagan@openedev.com] > Sent: Wednesday, November 16, 2016 9:33 AM > To: u-boot@lists.denx.de > Cc: Jagan Teki <jagan@openedev.com>; Bin Meng <bmeng.cn@gmail.com>; > York Sun <york.sun@nxp.com>; Vignesh R <vigneshr@ti.com>; Mugunthan V > N <mugunthanvnm@ti.com>; Michal Simek <michal.simek@xilinx.com>; Siva > Durga Prasad Paladugu <sivadur@xilinx.com> > Subject: [PATCH v6 08/21] sf: Add INFO6 flash_info macro > > INFO6 is for tabulating 6 byte flash parts, Ex: S25FS256S_64K > > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: York Sun <york.sun@nxp.com> > Cc: Vignesh R <vigneshr@ti.com> > Cc: Mugunthan V N <mugunthanvnm@ti.com> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > Signed-off-by: Jagan Teki <jagan@openedev.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Jagan Teki <jagan@openedev.com> > Tested-by: Jagan Teki <jagan@openedev.com> > --- > drivers/mtd/spi/sf_params.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index > d46a276..d0c978e 100644 > --- a/drivers/mtd/spi/sf_params.c > +++ b/drivers/mtd/spi/sf_params.c > @@ -27,6 +27,21 @@ > .page_size = 256, \ > .flags = (_flags), > > +#define INFO6(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \ > + .id = { \ > + ((_jedec_id) >> 16) & 0xff, \ > + ((_jedec_id) >> 8) & 0xff, \ > + (_jedec_id) & 0xff, \ > + ((_ext_id) >> 16) & 0xff, \ > + ((_ext_id) >> 8) & 0xff, \ > + (_ext_id) & 0xff, \ > + }, \ > + .id_len = 6, Why cant you use macro which you defined in 07/21. Thanks, Siva \ > + .sector_size = (_sector_size), \ > + .n_sectors = (_n_sectors), \ > + .page_size = 256, \ > + .flags = (_flags), > + > /* SPI/QSPI flash device params structure */ const struct spi_flash_info > spi_flash_ids[] = { > #ifdef CONFIG_SPI_FLASH_ATMEL /* ATMEL */ > -- > 1.9.1
On Wed, Nov 16, 2016 at 11:39 AM, Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> wrote: > Hi, > >> -----Original Message----- >> From: Jagan Teki [mailto:jagan@openedev.com] >> Sent: Wednesday, November 16, 2016 9:33 AM >> To: u-boot@lists.denx.de >> Cc: Jagan Teki <jagan@openedev.com>; Bin Meng <bmeng.cn@gmail.com>; >> York Sun <york.sun@nxp.com>; Vignesh R <vigneshr@ti.com>; Mugunthan V >> N <mugunthanvnm@ti.com>; Michal Simek <michal.simek@xilinx.com>; Siva >> Durga Prasad Paladugu <sivadur@xilinx.com> >> Subject: [PATCH v6 08/21] sf: Add INFO6 flash_info macro >> >> INFO6 is for tabulating 6 byte flash parts, Ex: S25FS256S_64K >> >> Cc: Bin Meng <bmeng.cn@gmail.com> >> Cc: York Sun <york.sun@nxp.com> >> Cc: Vignesh R <vigneshr@ti.com> >> Cc: Mugunthan V N <mugunthanvnm@ti.com> >> Cc: Michal Simek <michal.simek@xilinx.com> >> Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com> >> Signed-off-by: Jagan Teki <jagan@openedev.com> >> Reviewed-by: Simon Glass <sjg@chromium.org> >> Reviewed-by: Jagan Teki <jagan@openedev.com> >> Tested-by: Jagan Teki <jagan@openedev.com> >> --- >> drivers/mtd/spi/sf_params.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index >> d46a276..d0c978e 100644 >> --- a/drivers/mtd/spi/sf_params.c >> +++ b/drivers/mtd/spi/sf_params.c >> @@ -27,6 +27,21 @@ >> .page_size = 256, \ >> .flags = (_flags), >> >> +#define INFO6(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \ >> + .id = { \ >> + ((_jedec_id) >> 16) & 0xff, \ >> + ((_jedec_id) >> 8) & 0xff, \ >> + (_jedec_id) & 0xff, \ >> + ((_ext_id) >> 16) & 0xff, \ >> + ((_ext_id) >> 8) & 0xff, \ >> + (_ext_id) & 0xff, \ >> + }, \ >> + .id_len = 6, > Why cant you use macro which you defined in 07/21. Mayn't be, SPI_FLASH_ID_MAX_LEN is 6 byte length but it may increase in future technically INFO6 id_len shouldn't be same as MAX_LEN. thanks!
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index d46a276..d0c978e 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -27,6 +27,21 @@ .page_size = 256, \ .flags = (_flags), +#define INFO6(_jedec_id, _ext_id, _sector_size, _n_sectors, _flags) \ + .id = { \ + ((_jedec_id) >> 16) & 0xff, \ + ((_jedec_id) >> 8) & 0xff, \ + (_jedec_id) & 0xff, \ + ((_ext_id) >> 16) & 0xff, \ + ((_ext_id) >> 8) & 0xff, \ + (_ext_id) & 0xff, \ + }, \ + .id_len = 6, \ + .sector_size = (_sector_size), \ + .n_sectors = (_n_sectors), \ + .page_size = 256, \ + .flags = (_flags), + /* SPI/QSPI flash device params structure */ const struct spi_flash_info spi_flash_ids[] = { #ifdef CONFIG_SPI_FLASH_ATMEL /* ATMEL */