| Message ID | 1479257416-29389-13-git-send-email-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | a7747affae98636f5dd18401538513056771343e |
| Delegated to: | Tom Rini |
| Headers | show |
On 11/16/2016 01:50 AM, Andre Przywara wrote: > The shortname variable isn't referenced anywhere in the code, so just > remove it. > > Pointed out by a GCC 6.2 default warning option. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/usb/gadget/ether.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index 497b981..a210d33 100644 > --- a/drivers/usb/gadget/ether.c > +++ b/drivers/usb/gadget/ether.c > @@ -76,7 +76,6 @@ unsigned packet_received, packet_sent; > /* Based on linux 2.6.27 version */ > #define DRIVER_VERSION "May Day 2005" > > -static const char shortname[] = "ether"; > static const char driver_desc[] = DRIVER_DESC; > > #define RX_EXTRA 20 /* guard against rx overflows */ > Reviewed-by: Marek Vasut <marex@denx.de>
Hi Andre, > The shortname variable isn't referenced anywhere in the code, so just > remove it. > > Pointed out by a GCC 6.2 default warning option. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/usb/gadget/ether.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index 497b981..a210d33 100644 > --- a/drivers/usb/gadget/ether.c > +++ b/drivers/usb/gadget/ether.c > @@ -76,7 +76,6 @@ unsigned packet_received, packet_sent; > /* Based on linux 2.6.27 version */ > #define DRIVER_VERSION "May Day 2005" > > -static const char shortname[] = "ether"; > static const char driver_desc[] = DRIVER_DESC; > > #define RX_EXTRA 20 /* guard against rx > overflows */ Acked-by: Lukasz Majewski <l.majewski@samsung.com>
On Wed, Nov 16, 2016 at 12:50:16AM +0000, Andre Przywara wrote: > The shortname variable isn't referenced anywhere in the code, so just > remove it. > > Pointed out by a GCC 6.2 default warning option. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Reviewed-by: Marek Vasut <marex@denx.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> Applied to u-boot/master, thanks!
On Wed, Nov 16, 2016 at 12:50:16AM +0000, Andre Przywara wrote: > The shortname variable isn't referenced anywhere in the code, so just > remove it. > > Pointed out by a GCC 6.2 default warning option. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Reviewed-by: Marek Vasut <marex@denx.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> Applied to u-boot/master, thanks!
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index 497b981..a210d33 100644 --- a/drivers/usb/gadget/ether.c +++ b/drivers/usb/gadget/ether.c @@ -76,7 +76,6 @@ unsigned packet_received, packet_sent; /* Based on linux 2.6.27 version */ #define DRIVER_VERSION "May Day 2005" -static const char shortname[] = "ether"; static const char driver_desc[] = DRIVER_DESC; #define RX_EXTRA 20 /* guard against rx overflows */
The shortname variable isn't referenced anywhere in the code, so just remove it. Pointed out by a GCC 6.2 default warning option. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/usb/gadget/ether.c | 1 - 1 file changed, 1 deletion(-)