diff mbox

[U-Boot,10/12] cmd: tpm_test: fix indentation

Message ID 1479257416-29389-11-git-send-email-andre.przywara@arm.com
State Deferred
Delegated to: Tom Rini
Headers show

Commit Message

Andre Przywara Nov. 16, 2016, 12:50 a.m. UTC
The final line with the linefeeds should obviously only printed once
(what the code actually does), but the indentation suggests otherwise.

Fix the indentation to avoid compiler warnings and puzzled readers.

Pointed out by GCC 6.2's -Wmisleading-indentation warning.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 cmd/tpm_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Nov. 17, 2016, 7:50 p.m. UTC | #1
On 15 November 2016 at 17:50, Andre Przywara <andre.przywara@arm.com> wrote:
> The final line with the linefeeds should obviously only printed once
> (what the code actually does), but the indentation suggests otherwise.
>
> Fix the indentation to avoid compiler warnings and puzzled readers.
>
> Pointed out by GCC 6.2's -Wmisleading-indentation warning.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  cmd/tpm_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/cmd/tpm_test.c b/cmd/tpm_test.c
index 65332d1..576e4fb 100644
--- a/cmd/tpm_test.c
+++ b/cmd/tpm_test.c
@@ -539,8 +539,8 @@  static int do_tpmtest(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 		for (i = 0; i < argc; i++)
 			printf(" %s", argv[i]);
-			printf("\n------\n");
-		} while (0);
+		printf("\n------\n");
+	} while (0);
 	argc--;
 	argv++;
 	c = find_cmd_tbl(argv[0], cmd_cros_tpm_sub,