| Message ID | 1479257416-29389-8-git-send-email-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | 566a965af1d8c6151bb7c11cb55c9bd32cfeae8c |
| Delegated to: | Tom Rini |
| Headers | show |
On 11/16/2016 01:50 AM, Andre Przywara wrote: > Apparently the indentation is wrong here, fix this to avoid compiler > warnings and puzzled readers. > > Pointed out by GCC 6.2's -Wmisleading-indentation warning. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Reviewed-by: Marek Vasut <marex@denx.de> > --- > drivers/usb/eth/r8152_fw.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/eth/r8152_fw.c b/drivers/usb/eth/r8152_fw.c > index b6c8228..81c3754 100644 > --- a/drivers/usb/eth/r8152_fw.c > +++ b/drivers/usb/eth/r8152_fw.c > @@ -871,10 +871,10 @@ void r8153_firmware(struct r8152 *tp) > } else if (tp->version == RTL_VER_04) { > r8153_pre_ram_code(tp, 0x7001); > > - for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2) > - ocp_write_word(tp, MCU_TYPE_PLA, > - r8153_ram_code_bc[i], > - r8153_ram_code_bc[i+1]); > + for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2) > + ocp_write_word(tp, MCU_TYPE_PLA, > + r8153_ram_code_bc[i], > + r8153_ram_code_bc[i+1]); > > r8153_post_ram_code(tp); > >
On Tue, Nov 15, 2016 at 6:50 PM, Andre Przywara <andre.przywara@arm.com> wrote: > Apparently the indentation is wrong here, fix this to avoid compiler > warnings and puzzled readers. > > Pointed out by GCC 6.2's -Wmisleading-indentation warning. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On Wed, Nov 16, 2016 at 12:50:11AM +0000, Andre Przywara wrote: > Apparently the indentation is wrong here, fix this to avoid compiler > warnings and puzzled readers. > > Pointed out by GCC 6.2's -Wmisleading-indentation warning. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Reviewed-by: Marek Vasut <marex@denx.de> > Acked-by: Joe Hershberger <joe.hershberger@ni.com> Applied to u-boot/master, thanks!
diff --git a/drivers/usb/eth/r8152_fw.c b/drivers/usb/eth/r8152_fw.c index b6c8228..81c3754 100644 --- a/drivers/usb/eth/r8152_fw.c +++ b/drivers/usb/eth/r8152_fw.c @@ -871,10 +871,10 @@ void r8153_firmware(struct r8152 *tp) } else if (tp->version == RTL_VER_04) { r8153_pre_ram_code(tp, 0x7001); - for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2) - ocp_write_word(tp, MCU_TYPE_PLA, - r8153_ram_code_bc[i], - r8153_ram_code_bc[i+1]); + for (i = 0; i < ARRAY_SIZE(r8153_ram_code_bc); i += 2) + ocp_write_word(tp, MCU_TYPE_PLA, + r8153_ram_code_bc[i], + r8153_ram_code_bc[i+1]); r8153_post_ram_code(tp);
Apparently the indentation is wrong here, fix this to avoid compiler warnings and puzzled readers. Pointed out by GCC 6.2's -Wmisleading-indentation warning. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/usb/eth/r8152_fw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)