Patchwork Fix missing dependency of PCH_GBE driver

login
register
mail settings
Submitter David Miller
Date Oct. 28, 2010, 5:16 p.m.
Message ID <20101028.101618.226776102.davem@davemloft.net>
Download mbox | patch
Permalink /patch/69476/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - Oct. 28, 2010, 5:16 p.m.
From: Steven Rostedt <rostedt@goodmis.org>
Date: Thu, 28 Oct 2010 08:16:29 -0400

> While doing some randconfigs I stumbled across this build error:
> 
> ERROR: "mii_ethtool_gset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "generic_mii_ioctl" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_nway_restart" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_check_gmii_support" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_link_ok" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_ethtool_sset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> 
> The config option PCH_GBE is missing the dependency of MII.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

The canonical way to handle this is to use 'select'.  Thus,
I've committed the following to fix this.

Thanks.

--------------------
pch_gbe: Select MII.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Steven Rostedt - Oct. 28, 2010, 5:31 p.m.
On Thu, 2010-10-28 at 10:16 -0700, David Miller wrote:

> The canonical way to handle this is to use 'select'.  Thus,
> I've committed the following to fix this.

Yeah, I was thinking that too after I posted it.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 77c1fab..f24179d 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2520,6 +2520,7 @@  source "drivers/net/stmmac/Kconfig"
 config PCH_GBE
 	tristate "PCH Gigabit Ethernet"
 	depends on PCI
+	select MII
 	---help---
 	  This is a gigabit ethernet driver for Topcliff PCH.
 	  Topcliff PCH is the platform controller hub that is used in Intel's