diff mbox

[BUG,net-2.6,vlan/bonding] lockdep splats

Message ID 20101027120334.GA11247@ff.dom.local
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Jarek Poplawski Oct. 27, 2010, 12:03 p.m. UTC 
On Wed, Oct 27, 2010 at 12:24:30PM +0200, Eric Dumazet wrote:
> On latest net-2.6 kernel I got following splat, not sure its related to
> vlan changes...

Seems to be even older. Could you try this patch?

Thanks,
Jarek P.
---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Dumazet Oct. 27, 2010, 1 p.m. UTC | #1 
Le mercredi 27 octobre 2010 à 12:03 +0000, Jarek Poplawski a écrit :

> Seems to be even older. Could you try this patch?

Indeed this is the right fix, I wonder why I did not catch it before ?

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index beb3b7c..bdb68a6 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -493,9 +493,9 @@  static void bond_vlan_rx_register(struct net_device *bond_dev,
 	struct slave *slave;
 	int i;
 
-	write_lock(&bond->lock);
+	write_lock_bh(&bond->lock);
 	bond->vlgrp = grp;
-	write_unlock(&bond->lock);
+	write_unlock_bh(&bond->lock);
 
 	bond_for_each_slave(bond, slave, i) {
 		struct net_device *slave_dev = slave->dev;