mbox

[PULL,00/47] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

Message ID 1478794177-29377-1-git-send-email-mst@redhat.com
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

Message

Michael S. Tsirkin Nov. 10, 2016, 4:12 p.m. UTC 
The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:

  MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:

  docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)

----------------------------------------------------------------
virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

Lots of fixes all over the place.  I allowed some cleanups in even though they
are not strictly bugfixes, they might prevent bugs and seem very safe.

Most importantly, this fixes a regression with vhost introduced
by the last pull.

libvhost-user is the only thing that might be controvertial here, but it's only
affecting contrib/ and tests so I think it's still fair game, and several of
people were asking for it.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Cao jin (11):
      pcie_aer: Convert pcie_aer_init to Error
      msix: Follow CODING_STYLE
      hcd-xhci: check & correct param before using it
      pci: Convert msix_init() to Error and fix callers to check it
      megasas: change behaviour of msix switch
      hcd-xhci: change behaviour of msix switch
      megasas: remove unnecessary megasas_use_msix()
      megasas: undo the overwrites of msi user configuration
      vmxnet3: fix reference leak issue
      vmxnet3: remove unnecessary internal msix flag
      msi_init: convert assert to return -errno

Felipe Franciosi (2):
      vhost: Update 'ioeventfd_started' with host notifiers
      vhost: Use vbus var instead of VIRTIO_BUS() macro

Gonglei (1):
      virtio-crypto: tag as not hotpluggable and migration

Greg Kurz (3):
      vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout
      vhost: drop legacy vring layout bits
      virtio: drop virtio_queue_get_ring_{size,addr}()

Jason Wang (1):
      intel_iommu: fixing source id during IOTLB hash key calculation

Ladi Prosek (2):
      virtio: rename virtqueue_discard to virtqueue_unpop
      virtio: make virtqueue_alloc_element static

Marc-André Lureau (6):
      tests/vhost-user-bridge: remove false comment
      tests/vhost-user-bridge: remove unnecessary dispatcher_remove
      tests/vhost-user-bridge: indicate peer disconnected
      tests/vhost-user-bridge: do not accept more than one connection
      contrib: add libvhost-user
      tests/vhost-user-bridge: use contrib/libvhost-user

Marcel Apfelbaum (1):
      docs: add PCIe devices placement guidelines

Michael S. Tsirkin (2):
      virtio: allow per-device-class legacy features
      virtio-net: mark VIRTIO_NET_F_GSO as legacy

Peter Xu (3):
      intel_iommu: fix several incorrect endianess and bit fields
      intel_iommu: fix incorrect assert
      acpi: fix DMAR device scope for IOAPIC

Rafael David Tinoco (1):
      vhost: migration blocker only if shared log is used

Xiao Guangrong (14):
      qdev: hotplug: drop HotplugHandler.post_plug callback
      nvdimm acpi: drop the lock of fit buffer
      pc: memhp: move nvdimm hotplug out of memory hotplug
      pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug
      nvdimm acpi: clean up nvdimm_build_acpi
      docs: improve the doc of Read FIT method
      nvdimm acpi: rename nvdimm_plugged_device_list
      nvdimm acpi: cleanup nvdimm_build_fit
      nvdimm acpi: rename nvdimm_acpi_hotplug
      nvdimm acpi: define DSM return codes
      nvdimm acpi: fix two comments
      nvdimm acpi: rename nvdimm_dsm_reserved_root
      nvdimm acpi: use aml_name_decl to define named object
      nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE

 Makefile                                |    1 +
 Makefile.objs                           |    2 +-
 contrib/libvhost-user/libvhost-user.h   |  435 +++++++++
 hw/i386/intel_iommu_internal.h          |    2 +-
 include/hw/acpi/acpi-defs.h             |    5 +-
 include/hw/hotplug.h                    |   11 -
 include/hw/i386/intel_iommu.h           |    9 +-
 include/hw/mem/nvdimm.h                 |   20 +-
 include/hw/pci/msix.h                   |    5 +-
 include/hw/pci/pcie_aer.h               |    3 +-
 include/hw/virtio/vhost.h               |    7 +-
 include/hw/virtio/virtio.h              |   12 +-
 contrib/libvhost-user/libvhost-user.c   | 1499 +++++++++++++++++++++++++++++++
 hw/acpi/ich9.c                          |    8 +-
 hw/acpi/memory_hotplug.c                |   31 +-
 hw/acpi/nvdimm.c                        |  166 ++--
 hw/acpi/piix4.c                         |    7 +-
 hw/block/nvme.c                         |    5 +-
 hw/core/hotplug.c                       |   11 -
 hw/core/qdev.c                          |   20 +-
 hw/i386/acpi-build.c                    |    3 +-
 hw/i386/intel_iommu.c                   |    6 +-
 hw/i386/pc.c                            |   29 +-
 hw/misc/ivshmem.c                       |    8 +-
 hw/net/e1000e.c                         |    8 +-
 hw/net/rocker/rocker.c                  |    7 +-
 hw/net/virtio-net.c                     |    3 +-
 hw/net/vmxnet3.c                        |   46 +-
 hw/pci-bridge/ioh3420.c                 |    3 +-
 hw/pci-bridge/xio3130_downstream.c      |    3 +-
 hw/pci-bridge/xio3130_upstream.c        |    3 +-
 hw/pci/msi.c                            |    9 +-
 hw/pci/msix.c                           |   42 +-
 hw/pci/pcie_aer.c                       |   17 +-
 hw/s390x/virtio-ccw.c                   |    4 +-
 hw/scsi/megasas.c                       |   49 +-
 hw/usb/hcd-xhci.c                       |   71 +-
 hw/vfio/pci.c                           |    8 +-
 hw/virtio/vhost.c                       |  106 ++-
 hw/virtio/virtio-balloon.c              |    2 +-
 hw/virtio/virtio-crypto-pci.c           |    2 +-
 hw/virtio/virtio-crypto.c               |    1 +
 hw/virtio/virtio-pci.c                  |   15 +-
 hw/virtio/virtio.c                      |   23 +-
 tests/vhost-user-bridge.c               | 1183 +++++-------------------
 contrib/libvhost-user/Makefile.objs     |    1 +
 default-configs/mips-softmmu-common.mak |    1 +
 docs/pcie.txt                           |  310 +++++++
 docs/specs/acpi_mem_hotplug.txt         |    3 -
 docs/specs/acpi_nvdimm.txt              |   99 +-
 tests/Makefile.include                  |    2 +-
 51 files changed, 2940 insertions(+), 1386 deletions(-)
 create mode 100644 contrib/libvhost-user/libvhost-user.h
 create mode 100644 contrib/libvhost-user/libvhost-user.c
 create mode 100644 contrib/libvhost-user/Makefile.objs
 create mode 100644 docs/pcie.txt

Comments

Alex Williamson Nov. 10, 2016, 10:29 p.m. UTC | #1 
On Thu, 10 Nov 2016 18:12:20 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> 
>   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> 
> for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> 
>   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> 
> ----------------------------------------------------------------
> virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> 
> Lots of fixes all over the place.  I allowed some cleanups in even though they
> are not strictly bugfixes, they might prevent bugs and seem very safe.
> 
> Most importantly, this fixes a regression with vhost introduced
> by the last pull.

I think I'm hitting this previous regression, I see this in my libvirt
log:

kvm_mem_ioeventfd_add: error adding ioeventfd: File exists

And a backtrace as seen here
https://paste.fedoraproject.org/477562/88144131/

So I merge this tag to try to resolve it, now I get qemu segfaulting
bisected to:

commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
Author: Cao jin <caoj.fnst@cn.fujitsu.com>
Date:   Sat Nov 5 10:07:21 2016 +0800

    hcd-xhci: check & correct param before using it

And if I revert that, vhost still fails with:

qemu-system-x86_64: /net/gimli/home/alwillia/Work/qemu.git/memory.c:2012: memory_region_del_eventfd: Assertion `i != mr->ioeventfd_nb' failed.

So I think this does not fix the previous regression and adds a new
one :-\

Thanks,
Alex
Michael S. Tsirkin Nov. 10, 2016, 10:33 p.m. UTC | #2 
On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:
> On Thu, 10 Nov 2016 18:12:20 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> > 
> >   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > 
> > for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> > 
> >   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> > 
> > ----------------------------------------------------------------
> > virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> > 
> > Lots of fixes all over the place.  I allowed some cleanups in even though they
> > are not strictly bugfixes, they might prevent bugs and seem very safe.
> > 
> > Most importantly, this fixes a regression with vhost introduced
> > by the last pull.
> 
> I think I'm hitting this previous regression, I see this in my libvirt
> log:
> 
> kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
> 
> And a backtrace as seen here
> https://paste.fedoraproject.org/477562/88144131/
> 
> So I merge this tag to try to resolve it, now I get qemu segfaulting
> bisected to:
> 
> commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> Date:   Sat Nov 5 10:07:21 2016 +0800
> 
>     hcd-xhci: check & correct param before using it
> 
> And if I revert that, vhost still fails with:
> 
> qemu-system-x86_64: /net/gimli/home/alwillia/Work/qemu.git/memory.c:2012: memory_region_del_eventfd: Assertion `i != mr->ioeventfd_nb' failed.
> 
> So I think this does not fix the previous regression and adds a new
> one :-\
> 
> Thanks,
> Alex


Thanks!
Stefan, pls defer merging while we investigate.

Cc a bunch of relevant people.
Alex Williamson Nov. 10, 2016, 10:48 p.m. UTC | #3 
On Fri, 11 Nov 2016 00:33:17 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:
> > On Thu, 10 Nov 2016 18:12:20 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >   
> > > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> > > 
> > >   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > > 
> > > for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> > > 
> > >   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> > > 
> > > ----------------------------------------------------------------
> > > virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> > > 
> > > Lots of fixes all over the place.  I allowed some cleanups in even though they
> > > are not strictly bugfixes, they might prevent bugs and seem very safe.
> > > 
> > > Most importantly, this fixes a regression with vhost introduced
> > > by the last pull.  
> > 
> > I think I'm hitting this previous regression, I see this in my libvirt
> > log:
> > 
> > kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
> > 
> > And a backtrace as seen here
> > https://paste.fedoraproject.org/477562/88144131/
> > 
> > So I merge this tag to try to resolve it, now I get qemu segfaulting
> > bisected to:
> > 
> > commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> > Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> > Date:   Sat Nov 5 10:07:21 2016 +0800
> > 
> >     hcd-xhci: check & correct param before using it

Here's the backtrace from this one:

#0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
#1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
    at hw/usb/hcd-xhci.c:2870
#2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
    at hw/usb/hcd-xhci.c:2905
#3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
    at hw/usb/hcd-xhci.c:2961
#4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
    at hw/core/qdev.c:1145
#5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
    at hw/core/qdev.c:295
#6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
#7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
#8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
#9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
#10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
    at hw/core/qdev.c:321
#11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
    at hw/core/qdev.c:327
#12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
#13 0x00005555558367ce in pc_machine_reset ()
    at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
#14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
#15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656

Here's a commandline sufficient to trigger it:

qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci

So apparently that never got tested or something got mangled in the
commit.  Thanks,

Alex
Michael S. Tsirkin Nov. 10, 2016, 10:51 p.m. UTC | #4 
On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
> On Fri, 11 Nov 2016 00:33:17 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:
> > > On Thu, 10 Nov 2016 18:12:20 +0200
> > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > >   
> > > > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> > > > 
> > > >   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> > > > 
> > > > are available in the git repository at:
> > > > 
> > > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > > > 
> > > > for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> > > > 
> > > >   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> > > > 
> > > > ----------------------------------------------------------------
> > > > virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> > > > 
> > > > Lots of fixes all over the place.  I allowed some cleanups in even though they
> > > > are not strictly bugfixes, they might prevent bugs and seem very safe.
> > > > 
> > > > Most importantly, this fixes a regression with vhost introduced
> > > > by the last pull.  
> > > 
> > > I think I'm hitting this previous regression, I see this in my libvirt
> > > log:
> > > 
> > > kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
> > > 
> > > And a backtrace as seen here
> > > https://paste.fedoraproject.org/477562/88144131/
> > > 
> > > So I merge this tag to try to resolve it, now I get qemu segfaulting
> > > bisected to:
> > > 
> > > commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> > > Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> > > Date:   Sat Nov 5 10:07:21 2016 +0800
> > > 
> > >     hcd-xhci: check & correct param before using it
> 
> Here's the backtrace from this one:
> 
> #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
> #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
>     at hw/usb/hcd-xhci.c:2870
> #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
>     at hw/usb/hcd-xhci.c:2905
> #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
>     at hw/usb/hcd-xhci.c:2961
> #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
>     at hw/core/qdev.c:1145
> #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
>     at hw/core/qdev.c:295
> #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
> #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
> #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
>     at hw/core/qdev.c:321
> #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
>     at hw/core/qdev.c:327
> #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
> #13 0x00005555558367ce in pc_machine_reset ()
>     at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
> #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
> #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
> 
> Here's a commandline sufficient to trigger it:
> 
> qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
> 
> So apparently that never got tested or something got mangled in the
> commit.  Thanks,
> 
> Alex

I think I'll drop this, this patchset was borderline useful anyway.
Michael S. Tsirkin Nov. 10, 2016, 11:09 p.m. UTC | #5 
On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
> On Fri, 11 Nov 2016 00:33:17 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:
> > > On Thu, 10 Nov 2016 18:12:20 +0200
> > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > >   
> > > > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> > > > 
> > > >   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> > > > 
> > > > are available in the git repository at:
> > > > 
> > > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > > > 
> > > > for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> > > > 
> > > >   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> > > > 
> > > > ----------------------------------------------------------------
> > > > virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> > > > 
> > > > Lots of fixes all over the place.  I allowed some cleanups in even though they
> > > > are not strictly bugfixes, they might prevent bugs and seem very safe.
> > > > 
> > > > Most importantly, this fixes a regression with vhost introduced
> > > > by the last pull.  
> > > 
> > > I think I'm hitting this previous regression, I see this in my libvirt
> > > log:
> > > 
> > > kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
> > > 
> > > And a backtrace as seen here
> > > https://paste.fedoraproject.org/477562/88144131/
> > > 
> > > So I merge this tag to try to resolve it, now I get qemu segfaulting
> > > bisected to:
> > > 
> > > commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> > > Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> > > Date:   Sat Nov 5 10:07:21 2016 +0800
> > > 
> > >     hcd-xhci: check & correct param before using it
> 
> Here's the backtrace from this one:
> 
> #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
> #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
>     at hw/usb/hcd-xhci.c:2870
> #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
>     at hw/usb/hcd-xhci.c:2905
> #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
>     at hw/usb/hcd-xhci.c:2961
> #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
>     at hw/core/qdev.c:1145
> #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
>     at hw/core/qdev.c:295
> #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
> #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
> #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
>     at hw/core/qdev.c:321
> #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
>     at hw/core/qdev.c:327
> #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
> #13 0x00005555558367ce in pc_machine_reset ()
>     at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
> #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
> #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
> 
> Here's a commandline sufficient to trigger it:
> 
> qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
> 
> So apparently that never got tested or something got mangled in the
> commit.  Thanks,
> 
> Alex

On the original tree (without this mangled pull), does one of
[PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers
and
[PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers

help?
Alex Williamson Nov. 10, 2016, 11:44 p.m. UTC | #6 
On Fri, 11 Nov 2016 01:09:05 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
> > On Fri, 11 Nov 2016 00:33:17 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >   
> > > On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:  
> > > > On Thu, 10 Nov 2016 18:12:20 +0200
> > > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > > >     
> > > > > The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
> > > > > 
> > > > >   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
> > > > > 
> > > > > are available in the git repository at:
> > > > > 
> > > > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > > > > 
> > > > > for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
> > > > > 
> > > > >   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
> > > > > 
> > > > > ----------------------------------------------------------------
> > > > > virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
> > > > > 
> > > > > Lots of fixes all over the place.  I allowed some cleanups in even though they
> > > > > are not strictly bugfixes, they might prevent bugs and seem very safe.
> > > > > 
> > > > > Most importantly, this fixes a regression with vhost introduced
> > > > > by the last pull.    
> > > > 
> > > > I think I'm hitting this previous regression, I see this in my libvirt
> > > > log:
> > > > 
> > > > kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
> > > > 
> > > > And a backtrace as seen here
> > > > https://paste.fedoraproject.org/477562/88144131/
> > > > 
> > > > So I merge this tag to try to resolve it, now I get qemu segfaulting
> > > > bisected to:
> > > > 
> > > > commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> > > > Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> > > > Date:   Sat Nov 5 10:07:21 2016 +0800
> > > > 
> > > >     hcd-xhci: check & correct param before using it  
> > 
> > Here's the backtrace from this one:
> > 
> > #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
> > #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
> >     at hw/usb/hcd-xhci.c:2870
> > #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
> >     at hw/usb/hcd-xhci.c:2905
> > #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
> >     at hw/usb/hcd-xhci.c:2961
> > #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
> >     at hw/core/qdev.c:1145
> > #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
> >     at hw/core/qdev.c:295
> > #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
> > #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> > #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
> > #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> > #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
> >     at hw/core/qdev.c:321
> > #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
> >     at hw/core/qdev.c:327
> > #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
> > #13 0x00005555558367ce in pc_machine_reset ()
> >     at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
> > #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
> > #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
> > 
> > Here's a commandline sufficient to trigger it:
> > 
> > qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
> > 
> > So apparently that never got tested or something got mangled in the
> > commit.  Thanks,
> > 
> > Alex  
> 
> On the original tree (without this mangled pull), does one of
> [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers
> and
> [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers

The latter I already have from your tag as f99d0d394758, adding the
former on top of your tag does not resolve the assert (I simply removed
the xhci device from the vm config to avoid the segfault).  Thanks,

Alex
John Fastabend Nov. 11, 2016, 12:03 a.m. UTC | #7 
On 16-11-10 03:44 PM, Alex Williamson wrote:
> On Fri, 11 Nov 2016 01:09:05 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
>> On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
>>> On Fri, 11 Nov 2016 00:33:17 +0200
>>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>>   
>>>> On Thu, Nov 10, 2016 at 03:29:21PM -0700, Alex Williamson wrote:  
>>>>> On Thu, 10 Nov 2016 18:12:20 +0200
>>>>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>>>>     
>>>>>> The following changes since commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6:
>>>>>>
>>>>>>   MAINTAINERS: Remove obsolete stable branches (2016-11-10 15:29:59 +0000)
>>>>>>
>>>>>> are available in the git repository at:
>>>>>>
>>>>>>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>>>>>>
>>>>>> for you to fetch changes up to 8038753b86f4cb1e79d4225a799395c4dae96b17:
>>>>>>
>>>>>>   docs: add PCIe devices placement guidelines (2016-11-10 18:08:06 +0200)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> virtio, vhost, pc, pci: tests, documentation, fixes and cleanups
>>>>>>
>>>>>> Lots of fixes all over the place.  I allowed some cleanups in even though they
>>>>>> are not strictly bugfixes, they might prevent bugs and seem very safe.
>>>>>>
>>>>>> Most importantly, this fixes a regression with vhost introduced
>>>>>> by the last pull.    
>>>>>
>>>>> I think I'm hitting this previous regression, I see this in my libvirt
>>>>> log:
>>>>>
>>>>> kvm_mem_ioeventfd_add: error adding ioeventfd: File exists
>>>>>
>>>>> And a backtrace as seen here
>>>>> https://paste.fedoraproject.org/477562/88144131/
>>>>>
>>>>> So I merge this tag to try to resolve it, now I get qemu segfaulting
>>>>> bisected to:
>>>>>
>>>>> commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
>>>>> Author: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>>> Date:   Sat Nov 5 10:07:21 2016 +0800
>>>>>
>>>>>     hcd-xhci: check & correct param before using it  
>>>
>>> Here's the backtrace from this one:
>>>
>>> #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
>>> #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
>>>     at hw/usb/hcd-xhci.c:2870
>>> #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
>>>     at hw/usb/hcd-xhci.c:2905
>>> #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
>>>     at hw/usb/hcd-xhci.c:2961
>>> #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
>>>     at hw/core/qdev.c:1145
>>> #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
>>>     at hw/core/qdev.c:295
>>> #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
>>> #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
>>> #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
>>> #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
>>> #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
>>>     at hw/core/qdev.c:321
>>> #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
>>>     at hw/core/qdev.c:327
>>> #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
>>> #13 0x00005555558367ce in pc_machine_reset ()
>>>     at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
>>> #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
>>> #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
>>>
>>> Here's a commandline sufficient to trigger it:
>>>
>>> qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
>>>
>>> So apparently that never got tested or something got mangled in the
>>> commit.  Thanks,
>>>
>>> Alex  
>>
>> On the original tree (without this mangled pull), does one of
>> [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers
>> and
>> [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers
> 
> The latter I already have from your tag as f99d0d394758, adding the
> former on top of your tag does not resolve the assert (I simply removed
> the xhci device from the vm config to avoid the segfault).  Thanks,
> 
> Alex
> 

hmm with those patches it doesn't even get past boot for me.

qemu-system-x86_64: /home/john/git/qemu/memory.c:2012:
memory_region_del_eventfd: Assertion `i != mr->ioeventfd_nb' failed.
Aborted (core dumped)

I need to run out for a bit but can look at it more tomorrow if needed.

.John
Cao jin Nov. 11, 2016, 2:46 a.m. UTC | #8 
On 11/11/2016 06:51 AM, Michael S. Tsirkin wrote:
> On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:

>>>> So I merge this tag to try to resolve it, now I get qemu segfaulting
>>>> bisected to:
>>>>
>>>> commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
>>>> Author: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>> Date:   Sat Nov 5 10:07:21 2016 +0800
>>>>
>>>>      hcd-xhci: check & correct param before using it
>>
>> Here's the backtrace from this one:
>>
>> #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
>> #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
>>      at hw/usb/hcd-xhci.c:2870
>> #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
>>      at hw/usb/hcd-xhci.c:2905
>> #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
>>      at hw/usb/hcd-xhci.c:2961
>> #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
>>      at hw/core/qdev.c:1145
>> #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
>>      at hw/core/qdev.c:295
>> #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
>> #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
>> #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
>> #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
>> #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
>>      at hw/core/qdev.c:321
>> #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
>>      at hw/core/qdev.c:327
>> #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
>> #13 0x00005555558367ce in pc_machine_reset ()
>>      at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
>> #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
>> #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
>>
>> Here's a commandline sufficient to trigger it:
>>
>> qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
>>
>> So apparently that never got tested or something got mangled in the
>> commit.  Thanks,
>>
>> Alex
>
> I think I'll drop this, this patchset was borderline useful anyway.
>

Really sorry for the issue, I moved usb_xhci_init() too far from its 
original place, results in the segmentation fault.

Could I send new version of this patch to fix it right now?
Michael S. Tsirkin Nov. 11, 2016, 3:32 a.m. UTC | #9 
On Fri, Nov 11, 2016 at 10:46:29AM +0800, Cao jin wrote:
> 
> 
> On 11/11/2016 06:51 AM, Michael S. Tsirkin wrote:
> > On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
> 
> > > > > So I merge this tag to try to resolve it, now I get qemu segfaulting
> > > > > bisected to:
> > > > > 
> > > > > commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978
> > > > > Author: Cao jin <caoj.fnst@cn.fujitsu.com>
> > > > > Date:   Sat Nov 5 10:07:21 2016 +0800
> > > > > 
> > > > >      hcd-xhci: check & correct param before using it
> > > 
> > > Here's the backtrace from this one:
> > > 
> > > #0  0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824
> > > #1  0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072)
> > >      at hw/usb/hcd-xhci.c:2870
> > > #2  0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0)
> > >      at hw/usb/hcd-xhci.c:2905
> > > #3  0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010)
> > >      at hw/usb/hcd-xhci.c:2961
> > > #4  0x0000555555984a2e in device_reset (dev=0x7fffbfb38010)
> > >      at hw/core/qdev.c:1145
> > > #5  0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0)
> > >      at hw/core/qdev.c:295
> > > #6  0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:610
> > > #7  0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> > > #8  0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/qdev.c:602
> > > #9  0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf <qdev_reset_one>, post_busfn=0x5555559828e2 <qbus_reset_one>, opaque=0x0) at hw/core/bus.c:59
> > > #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0)
> > >      at hw/core/qdev.c:321
> > > #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0)
> > >      at hw/core/qdev.c:327
> > > #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765
> > > #13 0x00005555558367ce in pc_machine_reset ()
> > >      at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181
> > > #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778
> > > #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656
> > > 
> > > Here's a commandline sufficient to trigger it:
> > > 
> > > qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci
> > > 
> > > So apparently that never got tested or something got mangled in the
> > > commit.  Thanks,
> > > 
> > > Alex
> > 
> > I think I'll drop this, this patchset was borderline useful anyway.
> > 
> 
> Really sorry for the issue, I moved usb_xhci_init() too far from its
> original place, results in the segmentation fault.
> 
> Could I send new version of this patch to fix it right now?
> 
> -- 
> Yours Sincerely,
> 
> Cao jin
> 

OK but I'd like to know which other patches
in the patchset are untested. You really must inform people
when you post untested patches.
Michael S. Tsirkin Nov. 11, 2016, 3:49 a.m. UTC | #10 
On Fri, Nov 11, 2016 at 11:51:34AM +0800, Cao jin wrote:
> 
> 
> On 11/11/2016 11:32 AM, Michael S. Tsirkin wrote:
> > On Fri, Nov 11, 2016 at 10:46:29AM +0800, Cao jin wrote:
> > > 
> > > 
> > > On 11/11/2016 06:51 AM, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
> > > 
> 
> > > > 
> > > > I think I'll drop this, this patchset was borderline useful anyway.
> > > > 
> > > 
> > > Really sorry for the issue, I moved usb_xhci_init() too far from its
> > > original place, results in the segmentation fault.
> > > 
> > > Could I send new version of this patch to fix it right now?
> > > 
> 
> > > 
> > 
> > OK but I'd like to know which other patches
> > in the patchset are untested. You really must inform people
> > when you post untested patches.
> > 
> 
> I see, really sorry for my mistake. My patches just pass make check, didn't
> test for each patch.
> -- 
> Yours Sincerely,
> 
> Cao jin
> 

I think it's best to drop them for now in this case.
Cao jin Nov. 11, 2016, 3:51 a.m. UTC | #11 
On 11/11/2016 11:32 AM, Michael S. Tsirkin wrote:
> On Fri, Nov 11, 2016 at 10:46:29AM +0800, Cao jin wrote:
>>
>>
>> On 11/11/2016 06:51 AM, Michael S. Tsirkin wrote:
>>> On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote:
>>

>>>
>>> I think I'll drop this, this patchset was borderline useful anyway.
>>>
>>
>> Really sorry for the issue, I moved usb_xhci_init() too far from its
>> original place, results in the segmentation fault.
>>
>> Could I send new version of this patch to fix it right now?
>>

>>
>
> OK but I'd like to know which other patches
> in the patchset are untested. You really must inform people
> when you post untested patches.
>

I see, really sorry for my mistake. My patches just pass make check, 
didn't test for each patch.
Michael S. Tsirkin Nov. 11, 2016, 9:48 p.m. UTC | #12 
Paolo tells me he has fixes for the kvm ioeventfd crashes
in vhost.  I would appreciate testing and reports.
Alex Williamson Nov. 11, 2016, 10:43 p.m. UTC | #13 
On Fri, 11 Nov 2016 23:48:58 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Paolo tells me he has fixes for the kvm ioeventfd crashes
> in vhost.  I would appreciate testing and reports.

I replied to Paolo's patch, it did not fix the problem for me.  Thanks,

Alex