diff mbox

[Fortran,committed] PR 71894: [OOP] ICE in gfc_add_component_ref, at fortran/class.c:227

Message ID CAKwh3qggYNdZs17PKowGb_wnH2_AdSsFcvyHhpP8kyDpJTHvEQ@mail.gmail.com
State New
Headers show

Commit Message

Janus Weil Nov. 9, 2016, 10:24 a.m. UTC 
Hi Andre,

sorry, didn't want to be impolite. I was just not aware that it makes
a big difference whether I attach the patch or post the link. Patch
below.

Cheers,
Janus






2016-11-09 10:54 GMT+01:00 Andre Vehreschild <vehre@gmx.de>:
> Hi Janus,
>
> may I ask you to attach also the "obvious" patches to the mail you send to the
> list? It is far more comfortable to take a look at the patch in the mail than
> open the webpage. Furthermore is it considered polite to attach the patches
> even when they are obvious. This is not to treat you badly, but to ensure a
> certain quality of gfortran. When a diff is attached I look at it, but I will
> not open the link, not when I am only on a mobile.
>
> Thank you in advance,
>         Andre
>
> On Wed, 9 Nov 2016 10:35:10 +0100
> Janus Weil <janus@gcc.gnu.org> wrote:
>
>> Hi all,
>>
>> I have committed to trunk another obvious patch to fix an ICE on invalid code:
>>
>> https://gcc.gnu.org/viewcvs?rev=241993&root=gcc&view=rev
>>
>> Cheers,
>> Janus
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
diff mbox

Patch

Index: gcc/fortran/class.c
===================================================================
--- gcc/fortran/class.c    (Revision 241992)
+++ gcc/fortran/class.c    (Arbeitskopie)
@@ -224,7 +224,8 @@  gfc_add_component_ref (gfc_expr *e, const char *na
     break;
       tail = &((*tail)->next);
     }
-  if (derived->components->next->ts.type == BT_DERIVED &&
+  if (derived->components && derived->components->next &&
+      derived->components->next->ts.type == BT_DERIVED &&
       derived->components->next->ts.u.derived == NULL)
     {
       /* Fix up missing vtype.  */